unify build systems of buffyboard and unl0kr

Also the option

option('man', type: 'boolean', value: true, description: 'Install manual pages')

can be useful. What do you think?

By Владимир Стоякин on 2024-09-26T08:02:50

Neat! This makes the build files a lot easier and less duplicative. Thank you!

The only thing I noticed is that libxkbcommon probably shouldn't be a shared dependency.

By Johannes Marbach on 2024-09-25T19:02:24

requested changes

By Johannes Marbach on 2024-09-25T19:02:24

resolved all threads

By Владимир Стоякин on 2024-09-26T08:02:50

added 1 commit

• 6f48daca - unify build systems of buffyboard and unl0kr

Compare with previous version

By Владимир Стоякин on 2024-09-26T08:11:42

Side notes.

1. Is it okay?

$./find-lvgl-sources.sh lvgl > /dev/null
find: 'lvgl/src/dev': No such file or directory
find: 'lvgl/src/extra': No such file or directory
find: 'lvgl/src/extra/widgets/keyboard': No such file or directory
find: 'lvgl/src/extra/widgets/msgbox': No such file or directory
find: 'lvgl/src/extra/widgets/span': No such file or directory
find: 'lvgl/src/hal': No such file or directory

2. Why do you use sort for machine input?

find "$1/src" -name 'lv_init.c' | LC_ALL=C sort

By Владимир Стоякин on 2024-09-26T17:37:12

Re 1: Oh, looks like those folders don't exist anymore. This doesn't (appear to) break anything but we should probably remove these folders from the script. I'll just do that on master separately. Thanks for flagging this.

Re 2: This came from !24 (diffs). It appears to matter for strictly reproducible builds.

By Johannes Marbach on 2024-09-26T17:37:12

added 1 commit

• ec21e5ea - unify build systems of buffyboard and unl0kr

Compare with previous version

By Владимир Стоякин on 2024-09-26T10:46:29

Looks great, thanks you very much! I'll add you to the changelog on master after merging.

By Johannes Marbach on 2024-09-26T17:39:17

approved this merge request

By Johannes Marbach on 2024-09-26T17:39:24

mentioned in commit 83509c53

By Johannes Marbach on 2024-09-26T17:39:36

merged