Remove gtk4.0 fork

added technical debt label

Apparently the only app depending on GTK4 only is megapixels, which we can probably ignore for this. ~~Apps depending on libadwaita are~~Some important apps depending on libadwaita are (full list of libadwaita reverse dependencies in alpine is here):

When these are ported to the new AdwDialog interface the patches to GTK4 can be removed. Gnome 46 probably fixes this for most of core Gnome apps.

Edit: Made the app list into a checklist, added calls.

Edit 2024-09-06: Ticked chatty, phosh-mobile-settings and postmarketos-welcome

Edit 2024-09-25: Ticked epiphany, gnome-calculator, gnome-calendar, gnome-console, gnome-contacts, gnome-control-center, gnome-software, gnome-weather, loupe, resources. Looking good!

By Teemu Ikonen on 2024-09-25T08:43:26

Todays edge update brought in these packages from Gnome 46: calls, gnome-calendar, gnome-console, gnome-control-center, gnome-usage, loupe.

Only gnome-calendar and gnome-usage use at least AdwAboutDialog and presumably have ported also other dialogs to AdwDialog. It looks like we still need to patch Gtk4.0 for this Gnome release cycle.

By Teemu Ikonen on 2024-03-21T19:17:41

There's a thin line to walk there. If we keep the fork, then we provide people with no motivation to actually contribute upstream and help them port their widgets. If we remove the fork, we will regress, and have the risk of annoyed people getting bugs filled upstream for things upstream care less than us, and that does not help our relationship with them. I've always been on the team of creating slight inconvenience. Hopefully now that there's a real upstream widget, I can convince you that it's the correct thing to do? Maybe together with an edge blogpost informing people about it?

By Pablo Correa Gomez on 2024-03-21T19:17:41

In principle I agree with you on creating incentives for porting, but basically all apps in the list above are either Gnome core apps which have AdwDialog support as a release goal (I suppose), or mobile focused replacements. I'm not sure how much influence pmOS dropping convenience features has in these cases.

Gnome seems to make monthly point releases, I suggest we wait 2-3 of these to re-evaluate this, after all libadwaita 1.5 is only a week old.

By Teemu Ikonen on 2024-03-21T19:57:37

Alright, let's re-evaluate in 47.alpha or similar!

By Pablo Correa Gomez on 2024-03-21T22:23:24

@tpikonen what do you think about the current status? At least in papers we are now using the dialogs, and I hope others also did, but did not follow it closely. I'd be very happy if we could drop this for 47

By Pablo Correa Gomez on 2024-07-01T13:57:39

There's no excuse any more to not use AdwDialog in libadwaita apps, so for those apps the GTK4 patches are not needed. That leaves app-like things using GTK4, but not libadwaita. I found at least these in alpine after a quick search:

czkawka-gui
freeciv-client-gtk4
image-roll
iwgtk
megapixels
pavucontrol
pidif
ripdrag
transmission-gtk

The list is not too long, some of these claim to be (and are) adaptive without libadwaita and some have obvious adaptive replacements (but some could use porting to libadwaita, so if someone is in need of a project, go ahead ). There's nothing here to justify keeping the GTK4 patches either, so feel free to drop the fork.

By Teemu Ikonen on 2024-07-01T14:50:51

Nice! Thanks a lot for the research! I just set the due date to 18th of September for GNOME's 47 release, as we don't package unstable things. But so happy to hear we finally have a deadline to drop this!

By Pablo Correa Gomez on 2024-07-01T15:09:09

changed due date to June 01, 2024

By Pablo Correa Gomez on 2024-03-21T22:23:30

changed due date to July 01, 2024

By Pablo Correa Gomez on 2024-03-21T22:23:38

changed milestone to %v24.12 Release

changed due date to September 18, 2024

By Pablo Correa Gomez on 2024-07-01T15:07:50

mentioned in issue #2565

By TheWhalingWind on 2024-07-14T02:21:12

mentioned in merge request !5607 (merged)

By Pablo Correa Gomez on 2024-09-17T21:20:25

changed title from Drop gtk4.0 fork to Remove gtk4.0 fork

By Newbyte on 2024-09-18T12:46:13

mentioned in commit f2474488

By Pablo Correa Gomez on 2024-09-23T14:34:51

mentioned in merge request !5622 (merged)

By Newbyte on 2024-09-23T17:42:29

mentioned in commit 634eeb21

By Pablo Correa Gomez on 2024-09-24T10:14:20

mentioned in commit 2509c70a

By Pablo Correa Gomez on 2024-09-26T12:35:19

closed

mentioned in commit 2509c70a

Remove gtk4.0 fork

Child items 0

Activity