[PinePhone] feedbackd Can't Use Indictaor LEDs

Describe your issue

What's the expected behaviour?

When a feedbackd event is sent, involving the LEDs, that the LEDs light up.

What's the current behaviour?

LEDs do not light up, printing in debug log:

(feedbackd:4537): fbd-dev-leds-WARNING **: 16:06:12.821: Failed to set led pattern: Failed to open /sys/devices/platform/leds/leds/green:indicator/pattern: No such file or directory

I believe this file is provided by kernel config CONFIG_LEDS_TRIGGER_PATTERN.

How to reproduce your issue?

Send an event with fbcli that uses the indicator LEDs.

What device are you using?

PinePhone

On what postmarketOS version did you encounter the issue?

• edge (master branch)
• stable (v20.05 branch)

On what environment did you encounter the issue?

Phone environments

• Phosh
• Plasma Mobile
• Sxmo

Other

• No environment
• GNOME
• KDE Plasma
• Kodi
• MATE
• Shelli
• Sway
• Weston
• Xfce4
• fbkeyboard
• i3wm

How did you get postmarketOS image?

• from https://images.postmarketos.org
• I built it using pmbootstrap
• It was preinstalled on my device

FWIW, I set CONFIG_LEDS_TRIGGER_PATTERN=y on the kernel from !1533 (closed), and that sysfs path in your error was created.

I've never used fbcli, can you post the exact options you are sending to it so I can test?

(note: this comment originally said that the sysfs path wasn't created, it was, my first attempt to find it failed)

By clayton craft on 2020-09-11T06:56:40

I've tried several events and don't see any LED. I'm not sure which 'debug log' you are looking in, where is it? Here are the events I tried:

• message-new-instant
• phone-incoming-call
• battery-low

By clayton craft on 2020-09-11T06:56:40

The LED not showing up is the problem.

Run:

killall feedbackd
G_MESSAGES_DEBUG=all G_LOG_LEVEL_INFO=all G_DEBUG=all DISPLAY=:0 /usr/libexec/feedbackd &
G_MESSAGES_DEBUG=all G_LOG_LEVEL_INFO=all G_DEBUG=all DISPLAY=:0 fbcli -E <event>

See All Events Here: https://source.puri.sm/Librem5/feedbackd/-/blob/master/data/default.json

Default Profile Is full so all events in quiet, silent, and full merge.

By TheBrokenRail on 2020-09-11T12:02:49

Thanks. The event seems to run, there's haptik feedback, but no LED and no error from feedbackd. I suspect the problem now might be with the newer kernel I'm testing. I'll ask that CONFIG_LEDS_TRIGGER_PATTERN is switched on in the kernel update being prepared now for the pinephone.

By clayton craft on 2020-09-11T16:43:47

What event did you use? One that uses the LED is message-missed-email.

By TheBrokenRail on 2020-09-11T17:04:14

I see, I used the wrong event (did I mention this is my first time playing with feedbackd yet? ) . With that kernel option enabled (on the 5.9 megi kernel..), I see a red led for battery-caution and blue led for message-missed-email.

By clayton craft on 2020-09-11T17:28:19

Yay!

By TheBrokenRail on 2020-09-11T17:58:48

I pushed the config change to the open MR for upgrading the pinephone kernel: !1569 (closed)

By clayton craft on 2020-09-11T18:01:49

added category::device type::bug labels

mentioned in merge request !1569 (closed)

By clayton craft on 2020-09-11T16:44:45

mentioned in commit e8314e84

By clayton craft on 2020-09-11T18:01:17

changed the description

By Antoine Fontaine on 2020-09-12T04:09:53

mentioned in commit 81acfdf1

By clayton craft on 2020-09-12T12:45:15

mentioned in issue pmbootstrap#1824

By clayton craft on 2020-09-14T06:26:46

mentioned in commit 193b1803

By clayton craft on 2020-09-14T06:51:49

mentioned in commit 0dc8eb9c

By clayton craft on 2020-09-14T20:26:55

closed

mentioned in commit 6db9a8fd

By clayton craft on 2020-09-14T20:44:24

mentioned in commit a5068834

By clayton craft on 2020-09-15T15:00:21