qemu-*: move from testing to main
Note: Do not merge this after two approvals. See https://wiki.postmarketos.org/wiki/Device_categorization#Moving_to_a_higher_category (discuss in https://gitlab.com/postmarketOS/postmarketos/-/issues/24 and https://gitlab.com/postmarketOS/postmarketos/-/issues/25).
For testing changes for device categorization, it is useful to have a device in each of the categories. The PinePhone is close to being moved to main/, but it doesn't fulfill all requirements yet.
The QEMU "device ports" are very simple since QEMU currently only emulates a rather limited set of hardware features. All available features are working correctly (especially after the recent rework of the QEMU packages). I suppose it is also usable as a "daily driver", at least for its intended purpose (a virtual machine for testing postmarketOS changes). :)
Given that everyone can run QEMU, everyone could potentially maintain it. For now I have added myself as maintainer since I did most of the recent cleanup.
Overall it seems useful to have qemu-* in main/, especially because
it is now the device that is selected by default in pmbootstrap.
I can try to come up with more reasons to have it in main/
, if anyone needs more to be convinced. :)
EDIT by ollieparanoid: link to review process in wiki
Merge request reports
Activity
- Resolved by Administrator
- Resolved by Administrator
In https://gitlab.com/postmarketOS/postmarketos/-/issues/24 I mentioned:
Everyone should be given the chance to look at the entire device port again, to identify issues/possible improvements like the above.
But commenting on particular parts of the device port isn't easy if they are not available for commenting. E.g. here on the files that were just moved.
Maybe we should open these kind of MRs with a copy of the device port (so everything shows up in the changes), and delete the old device port shortly before the MR is merged.
By Minecrell on 2020-04-04T10:58:48
changed milestone to %Device categorization
By Minecrell on 2020-04-04T11:24:39
Added @drebrez as second maintainer.
By Minecrell on 2020-04-05T12:35:00
added 10 commits
-
7663779e...ccbdea74 - 8 commits from branch
master
- ad5843ea - CI: test_directory_structure: Allow device/{community,main}
- 5b144428 - qemu-*: move from testing to main
By Minecrell on 2020-04-05T12:38:33
-
7663779e...ccbdea74 - 8 commits from branch
added category::device + 1 deleted label