Skip to content
Snippets Groups Projects

qemu-*: move from testing to main

Merged Imported Administrator requested to merge qemu-main into master

Note: Do not merge this after two approvals. See https://wiki.postmarketos.org/wiki/Device_categorization#Moving_to_a_higher_category (discuss in https://gitlab.com/postmarketOS/postmarketos/-/issues/24 and https://gitlab.com/postmarketOS/postmarketos/-/issues/25).

For testing changes for device categorization, it is useful to have a device in each of the categories. The PinePhone is close to being moved to main/, but it doesn't fulfill all requirements yet.

The QEMU "device ports" are very simple since QEMU currently only emulates a rather limited set of hardware features. All available features are working correctly (especially after the recent rework of the QEMU packages). I suppose it is also usable as a "daily driver", at least for its intended purpose (a virtual machine for testing postmarketOS changes). :)

Given that everyone can run QEMU, everyone could potentially maintain it. For now I have added myself as maintainer since I did most of the recent cleanup.

Overall it seems useful to have qemu-* in main/, especially because it is now the device that is selected by default in pmbootstrap.
I can try to come up with more reasons to have it in main/, if anyone needs more to be convinced. :)

EDIT by ollieparanoid: link to review process in wiki

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Author Owner
      Resolved by Administrator

      In https://gitlab.com/postmarketOS/postmarketos/-/issues/24 I mentioned:

      Everyone should be given the chance to look at the entire device port again, to identify issues/possible improvements like the above.

      But commenting on particular parts of the device port isn't easy if they are not available for commenting. E.g. here on the files that were just moved.

      Maybe we should open these kind of MRs with a copy of the device port (so everything shows up in the changes), and delete the old device port shortly before the MR is merged.

      By Minecrell on 2020-04-04T10:58:48

  • Administrator changed the description · Imported

    changed the description

    By Minecrell on 2020-04-04T11:24:39

  • Administrator changed milestone to %Device categorization · Imported

    changed milestone to %Device categorization

    By Minecrell on 2020-04-04T11:24:39

  • Author Owner

    I have looked at all of the device files and find them suitable for main. It's a great idea to put the qemu devices there :smiley:

    By Oliver Smith on 2020-04-04T22:33:10

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-04-04T22:33:12

  • Administrator changed the description · Imported

    changed the description

    By Oliver Smith on 2020-04-04T23:11:37

  • Administrator added 1 commit · Imported

    added 1 commit

    • 7663779e - qemu-*: move from testing to main

    Compare with previous version

    By Minecrell on 2020-04-05T12:34:44

  • Author Owner

    Added @drebrez as second maintainer.

    By Minecrell on 2020-04-05T12:35:00

  • Administrator resolved all threads · Imported

    resolved all threads

    By Minecrell on 2020-04-05T12:35:07

  • Administrator added 10 commits · Imported

    added 10 commits

    Compare with previous version

    By Minecrell on 2020-04-05T12:38:33

  • Author Owner

    (Rebased on master to fix "outdated pmaports" error)

    By Minecrell on 2020-04-05T12:38:52

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2020-04-05T13:08:58

  • Administrator added category::device + 1 deleted label · Imported

    added category::device + 1 deleted label

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-04-10T22:51:48

  • Administrator approved this merge request · Imported

    approved this merge request

    By Martijn Braam on 2020-04-10T22:54:08

  • Administrator approved this merge request · Imported

    approved this merge request

    By Luca Weiss on 2020-04-10T22:56:11

  • Administrator approved this merge request · Imported

    approved this merge request

    By Bart Ribbers on 2020-04-10T22:59:43

  • Administrator approved this merge request · Imported

    approved this merge request

    By Daniele Debernardi on 2020-04-11T01:08:57

  • Author Owner

    Is this the most approved MR? :sweat_smile:

    By Daniele Debernardi on 2020-04-11T01:10:23

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading