Skip to content
Snippets Groups Projects

motorola-cedric: Enable OTG.

Merged Imported Administrator requested to merge device/motorola-cedric into master

OTG was tested with a keyboard and a pendrive.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Hacker1245 on 2019-01-21T23:52:26

  • Author Owner

    The cleanest way would be having one commit per logical change. But then again, compiling a kernel takes time and the CI here won't verify if each independent commit compiles or not (only if the last commit in a MR builds). So I would suggest to make the multiple kernel changes in this MR/even in one commit, but mention each one explicitly (in the commit or at least in the MR description).

    Please revert the unrelated changes so we have a clean patch (pkgrel bump in device package, KGSL disabled). (Might be easier to start from "master" and then do the two changes you intended to do, instead of reverting the unintended changes.)

    Thanks for the MR @Hacker1245!

    By Oliver Smith on 2019-01-22T06:58:45

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Hacker1245 on 2019-01-22T09:42:35

  • Administrator added 1 commit · Imported

    added 1 commit

    • 518a737b - Enabled KGSL and PCI sound, kept OTG changes

    Compare with previous version

    By Hacker1245 on 2019-01-22T15:38:35

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Hacker1245 on 2019-01-22T15:39:13

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Hacker1245 on 2019-01-22T16:00:20

  • Author Owner

    Everything should be fixed.

    By Hacker1245 on 2019-01-22T17:01:23

  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Hacker1245 on 2019-01-22T19:57:57

  • Administrator added 1 commit · Imported

    added 1 commit

    • 787ac9f0 - Update config-motorola-cedric.aarch64

    Compare with previous version

    By Hacker1245 on 2019-01-22T20:12:49

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Hacker1245 on 2019-01-22T20:52:39

  • Author Owner

    There are sill a few changes that seem unrelated and maybe unnecessary. Have you tried enabling only CONFIG_USB_OTG?

    By Grant Miller on 2019-01-22T22:28:28

  • Author Owner

    Yes, didn't work @GrantM11235

    By Hacker1245 on 2019-01-22T23:04:22

  • Administrator added 8 commits · Imported

    added 8 commits

    Compare with previous version

    By Oliver Smith on 2019-01-23T08:50:53

  • Administrator resolved all discussions · Imported

    resolved all discussions

    By Oliver Smith on 2019-01-23T08:51:12

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading