Skip to content
Snippets Groups Projects

WIP: Librem 5 ofono integration

Closed Imported Administrator requested to merge bshah/librem5-ofono into master

Since right now I don't have access to the SIM which would fit in devkit, I can't test it to full extent, but here we go

Merge request reports

Approval is optional

Closed by AdministratorAdministrator 5 years ago (May 26, 2019 3:43pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    Looks good to me! Let me know when it is tested.

    Out of curiosity, which SIM type would be required?

    By Oliver Smith on 2019-03-02T13:41:46

    Edited by Administrator
  • Author Owner

    It needs Standard SIM (15 x 25mm), while all I have is Micro and Nano SIM

    By Bhushan Shah on 2019-03-02T13:45:56

  • Author Owner

    Kind of unrelated, but I think we should really try to not get stuck on an old ofono version where the patches don't apply (cleanly) on upstream master. We're currently on ofono 1.21 (released 17 months ago) and upstream is at version 1.28 (released 5 weeks ago).

    I've spent a bit of time on doing that and some patches we have locally are already upstream but most stuff doesn't apply nicely. See https://ptpb.pw/R5mc for what I did (seems that it was mostly just removing the call patches that you added but also temp_failure_retry.patch).

    By Luca Weiss on 2019-03-02T14:21:49

  • Author Owner

    @bshah are you sure you are not looking at the smartcard slot? The devkit uses a micro SIM card :) The SIM card slot is right next to the power button on the device.

    By clayton craft on 2019-03-02T21:11:58

  • Administrator mentioned in merge request !245 (merged) · Imported

    mentioned in merge request !245 (merged)

    By Oliver Smith on 2019-03-03T09:20:16

  • Author Owner

    What is stopping this MR from being merged? Is it still not tested?

    By Bart Ribbers on 2019-05-24T23:18:28

  • Author Owner

    Yes, unfortunately it was never reported as being tested.

    Plus now we have the issue that there is a newer ofono version in Alpine (#231 (closed); tl;dr: we have nexus 5 specific patches on top of ofono currently; there are new patches but nobody can confirm that they are working, ofono does not even find the modem on my hammerhead and also from two other testers, and while it seems to work for @MartijnBraam, SSH access was broken for him and that is why he could not test it?).

    Maybe this MR is useful for future reference, I have just linked to it in the device's wiki page. But in this state, this can't be used, so let's close it.

    (@PureTryOut, thanks for going through the open MRs btw!)

    By Oliver Smith on 2019-05-26T15:43:47

  • Administrator closed · Imported

    closed

    By Oliver Smith on 2019-05-26T15:43:52

  • Administrator mentioned in commit wiki@a30bfeb7 · Imported

    mentioned in commit wiki@a30bfeb7

    By postmarketOS Wiki bot on 2019-05-26T16:42:47

  • Administrator mentioned in commit postmarketos.org@531532de · Imported

    mentioned in commit postmarketos.org@531532de

    By f_ on 2024-03-07T11:10:56

  • Administrator mentioned in merge request postmarketos.org!253 (merged) · Imported

    mentioned in merge request postmarketos.org!253 (merged)

    By f_ on 2024-03-07T11:11:16

Please register or sign in to reply
Loading