Skip to content
Snippets Groups Projects

[RFC] mrhlpr.json: accept all generic package commits

Merged Imported Administrator requested to merge mrhlpr-simplify-regex into master

I don't think the current mrhlpr formats properly represent what commit subjects we actually accept, the rules about having "new aport", "pkgrel bump", "new device" etc are sensible, but the current implementation means that any commit message not matching one of those is denoted "unknown", and mrhlpr gets unhappy.

Asking contributors to fix commit messages for new packages/upgrades etc is currently an entirely manual process, mrhlpr just acts as a last line of defence here, although given how often I have to ignore it's warning I'm not sure how effective it is.

Perhaps we could create a git pre-commit hook which checks if the change is a new aport, upgrade, etc and warns the user about it?

Merge request reports

Checking pipeline status.

Merged by AdministratorAdministrator 2 years ago (Mar 15, 2023 9:38pm UTC)

Loading

Pipeline #205762 passed

Pipeline passed for 5ce568cd on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading