Skip to content
Snippets Groups Projects

sony-pioneer: new device

Merged Imported Administrator requested to merge sony-pioneer into master

This is based on the work at !1645 (closed). I used the port and adapted it according to the requested changes. As I only have this device to test it, I did not submit MRs for the other devices.

CC: @konradybcio as you created the original MR

Merge request reports

Checking pipeline status.

Approved by

Merged by AdministratorAdministrator 1 year ago (Jul 5, 2023 9:03pm UTC)

Merge details

  • Changes merged into master with c1d23e5f.
  • Deleted the source branch.

Pipeline #206501 passed

Pipeline passed for c1d23e5f on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator
  • Administrator
  • Author Owner

    Thanks @minlexx for the feedback. I will address the issues and report back when done :)

    By Max on 2023-06-30T08:10:48

  • Administrator added 2 commits · Imported

    added 2 commits

    • 19fccce9 - 1 commit from branch postmarketOS:master
    • cc3d7d2b - sony-pioneer: new device

    Compare with previous version

    By Max on 2023-06-30T08:12:25

  • Administrator added 11 commits · Imported

    added 11 commits

    Compare with previous version

    By Max on 2023-07-03T07:47:24

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Max on 2023-07-03T08:32:00

  • Administrator resolved all threads · Imported

    resolved all threads

    By Max on 2023-07-03T08:34:16

  • Author Owner

    Now the packages do not build anymore, I'll have a look at it. However you can already let me know what you think about the overall structure after I restructured the subpackages etc. Does this align with your thoughts?

    By Max on 2023-07-03T08:37:35

  • Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Max on 2023-07-03T13:13:25

  • Administrator resolved all threads · Imported

    resolved all threads

    By Max on 2023-07-03T13:13:32

  • Administrator
    • Author Owner
      Resolved by Administrator

      let me know if there are any further things you would like to see improved :)

      First of all let me say as fact that our little sdm660 kernel fork does not contain any special patches for any Sony devices, only things that are already in mainline kernel. That means you could not test the -rproc stuff that you're adding here, as is (unless you built your own kernel with extra patches). But it is work in progress - when I get my hands and head in order to send a V3 for this https://patchwork.kernel.org/project/linux-arm-msm/list/?series=759241&state=%2A&archive=both , we can start adding more stuff. So the common SoC package and rproc subpackage will be needed in the future.

      By the way, on msm8998 it was also required to run diag-router service to get Wi-Fi working, in addition to rmtfs and stuff (package qcom-diag and rc-service is diag-router) but I have not yet confirmed that it is strictly required.

      Since you are already adding untested stuff, you might as well add other SDM630 Sony-nile devices, even if you don't have them to test yourself (Sony Xperia XA2 Plus voyager, Sony Xperia XA2 Ultra discovery), since the only difference to pioneer is AFAIK screen size (and panel?). Btw I do not know what display panels are there in Sony phones, and if they are already in mainline, I hope you've verified that. But device trees are there in mainline, and supported by the kernel, so we might declare them supported in testing category.

      But I think this might be good enough for the start. Thanks :smile:

      By Alexey Min on 2023-07-04T03:26:14

      Edited by Administrator
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading