Feature/shelli ui
@MartijnBraam not sure how to proceed here. This is a MR to the postmarketos branch feature/shelli-ui, so maybe you can merge it in and we can proceed with the code review?
Have released both gesture and shelli and tested the pmaports changes locally building and on nexus 5.
The power key works fine for me and the freeze after sitting for about 5 minutes still happens for me but I don't consider that necessarily a shelli bug, maybe the code needs to feed a watchdog or something.
Merge request reports
Activity
- Resolved by Administrator
Yes this makes the MR a bit confusing, I rebased the feature/shelli-ui branch now. I guess the changes make more sense if you rebase your MR on top of feature/shelli-ui again.
By Martijn Braam on 2019-05-30T15:46:19
Edited by Administrator
mentioned in merge request !265 (closed)
By Oliver Smith on 2019-05-31T00:45:55
Code looks good to me. I've changed the target branch to master. But I'm not merging yet, since the other MR was set to WIP.
If you want to go the extra mile, it would be nice if you could squash the commits and use a good commit message.
@unrznbl: thanks again, and can we merge this?
By Oliver Smith on 2019-05-31T00:48:28
@ollieparanoid yep, was planning on squashing once it was looking good.
By Craig Comstock on 2019-05-31T02:27:30
added 15 commits
-
e285fffa...07cbc8cf - 14 commits from branch
postmarketOS:master
- 1d8c9445 - Add shelli a framebuffer console plus gesture recognition UI option
By Craig Comstock on 2019-05-31T02:36:08
-
e285fffa...07cbc8cf - 14 commits from branch
added 1 commit
- 8db49ca8 - Add postmarketos-ui-shelli, a framebuffer console plus gesture recognition UI option
By Craig Comstock on 2019-05-31T02:40:13
@ollieparanoid should be good to merge now. Thanks!
By Craig Comstock on 2019-05-31T02:40:36
added 7 commits
-
8db49ca8...36d68814 - 6 commits from branch
postmarketOS:master
- 3bba29a6 - Add postmarketos-ui-shelli (!397 (merged))
By Oliver Smith on 2019-06-01T21:07:45
-
8db49ca8...36d68814 - 6 commits from branch
enabled an automatic merge when the pipeline for 3bba29a6 succeeds
By Oliver Smith on 2019-06-01T21:12:26
mentioned in commit 3bba29a6
By Martijn Braam on 2019-06-11T15:01:33