Skip to content
Snippets Groups Projects

Add option to specify extra free space in pmbootstrap init

Merged Imported Administrator requested to merge feature/extra-space into master
All threads resolved!

This #1904 (closed) and adds a new commandline flag -E / --extra-space for specifying the amount of additional space to be added tothe image size to work around cases where the automatically determined size turns out to not actually be enough.

The value is also asked for in the "Additional options"section of the interactive mode.

This is my first ever merge request for pmbootstrap so I probably did a few things wrong. Happy to receive feedback. :)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    • 2b2babaf - Add option to specify extra free space in pmbootstrap init

    Compare with previous version

    By Johannes Marbach on 2020-11-17T19:05:21

  • Administrator added 2 commits · Imported

    added 2 commits

    • e6543332 - 1 commit from branch postmarketOS:master
    • 0d99319d - Add option to specify extra free space in pmbootstrap init

    Compare with previous version

    By Johannes Marbach on 2020-11-17T19:08:57

  • Administrator resolved all threads · Imported

    resolved all threads

    By Johannes Marbach on 2020-11-17T19:09:53

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2020-11-18T09:22:45

  • Author Owner

    Looks good to me, thanks again @cherrypicker!

    As per our approval requirements, you'll need another approval before this gets merged. (I'll ask in the #postmarketos-devel channel.)

    EDIT: I've verified that this works as intended :thumbsup:

    By Oliver Smith on 2020-11-18T09:33:03

    Edited by Administrator
  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2020-11-18T10:34:13

  • Administrator added 1 commit · Imported

    added 1 commit

    • 5dea3105 - Add option to specify extra free space in pmbootstrap init (MR 1989)

    Compare with previous version

    By Oliver Smith on 2020-11-18T13:08:44

  • Administrator enabled an automatic merge when the pipeline for 5dea3105 succeeds · Imported

    enabled an automatic merge when the pipeline for 5dea3105 succeeds

    By Oliver Smith on 2020-11-18T13:09:02

  • Author Owner

    CI failed because of GCC upgrade. I'll run it again after our gcc aports are adjusted.

    By Oliver Smith on 2020-11-18T13:24:06

  • Administrator merged · Imported

    merged

  • Administrator mentioned in issue #1916 (closed) · Imported

    mentioned in issue #1916 (closed)

    By Alexander Brzoska on 2020-12-23T12:58:40

  • Administrator mentioned in issue #1908 (closed) · Imported

    mentioned in issue #1908 (closed)

    By Oliver Smith on 2020-12-30T11:39:47

  • Please register or sign in to reply
    Loading