CI: Run mypy with --check-untyped-defs (!2431) · Merge requests · postmarketOS / pmbootstrap

Merged Newbyte requested to merge newbyte/untyped-defs-check into master 5 months ago

Oct 15, 2024

CI: Run mypy with --check-untyped-defs (MR 2431) · fb7f5353

Newbyte authored 5 months ago

All typing errors found with --check-untyped-defs have been fixed, so
let's make mypy stricter now to avoid regressing this.

Verified

fb7f5353

pmb.helpers.pmaports: Annotate return type for get_list() as list (MR 2431) · ce2fca6a

Newbyte authored 5 months ago

I'm not sure why this was annotated as a Sequence rather than list. The
function clearly returns a list, not a Sequence, and the commit that
originally did it[1] provides no justification. This causes problems
with mypy checks in other places, so let's just annotate this as
returning a list.

 [1]: 198f302a

Verified

ce2fca6a

pmb.helpers.logging: Annotate types for loglevels (MR 2431) · 7ed07fb6
Newbyte authored 5 months ago
```
Otherwise mypy cannot figure out the type of these.
```
Verified

7ed07fb6

CI: Run mypy with --check-untyped-defs

Merge request reports

Activity