Skip to content
Snippets Groups Projects

core: pkgrepo: support arbitrarily named pmaports directories

Merged Caleb Connolly requested to merge caleb/custom-pmaports into master

There was an oversight when this API was originally created and it implicitly assumed that the pmaports repository was always named "pmaports". This unfortunately broke some peoples workflows.

Introduce a new "pkgrepo_name()" function and adjust the codebase to use it, as well as adjusting pkgrepo internally to special case the "pmaports" repo so that it's always named pmaports no matter what the directory itself is named.

This is probably more complexity than we should be dealing with here, we should probably create a new type to encode this behaviour.


In addition, fix calling pmbootstrap init with --work which would half-work before, but you'd need to enter the new workdir a second time.

Fixes: #2412 (closed) Fixes: #2386 (closed)

Edited by Caleb Connolly

Merge request reports

Merge request pipeline #209533 passed

Merge request pipeline passed for d57b9e31

Approved by

Merged by Oliver SmithOliver Smith 4 months ago (Nov 3, 2024 12:27pm UTC)

Merge details

Pipeline #209539 passed

Pipeline passed for d57b9e31 on master

Deployed to dep‎loy‎ 4 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading