Skip to content
Snippets Groups Projects

test: fix and re-add bootimg analyze tests

Merged test: fix and re-add bootimg analyze tests
caleb/bootimg-analyze-tests into master
All threads resolved!
Merged Caleb Connolly requested to merge caleb/bootimg-analyze-tests into master
All threads resolved!

fix bootimg analyze unit tests

Merge request reports

Merge request pipeline #211143 passed

Stage: test
Stage: integration-test

Merge request pipeline passed for bb126097

Approved by
Oliver Smith

Merged by Oliver SmithOliver Smith 3 months ago (Nov 29, 2024 4:11pm UTC)

Merge details

  • Changes merged into master with bb126097.
  • Did not delete the source branch.
  • Auto-merge enabled

Pipeline #211144 failed

Stage: test
Stage: deploy
Stage: integration-test

Pipeline failed for bb126097 on master

Deployed to dep‎loy‎ 3 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Caleb Connolly added 5 commits

    added 5 commits

    • 36531c5e - Revert "CI: Add bootimg analysis integration test (MR 2467)"
    • 9e7ed56e - test: conftest: adjust pmaports fixture (MR 2477)
    • 8071733e - test: parse: add tests for bootimg parsing (MR 2477)
    • 8ef06b62 - test: aportgen: test deviceinfo fastboot content (MR 2477)
    • c0ef9ceb - test: conftest: require_programs() automatically

    Compare with previous version

    Toggle commit list
  • Caleb Connolly added 4 commits

    added 4 commits

    • 108d9125 - test: conftest: adjust pmaports fixture (MR 2477)
    • 3d02185f - test: parse: add tests for bootimg parsing (MR 2477)
    • 441f3e5a - test: aportgen: test deviceinfo fastboot content (MR 2477)
    • a7150dd9 - test: conftest: require_programs() automatically

    Compare with previous version

    Toggle commit list
  • Oliver Smith
  • Oliver Smith
  • Oliver Smith
    Oliver Smith @ollieparanoid ·
    Maintainer

    I think we should fix that pmaports gets cloned each time a test runs, and therefore we need to combine multiple tests into one. And we should make sure that CI really passes before merging. Otherwise LGTM. Thanks for making this!

  • Caleb Connolly unassigned @caleb

    unassigned @caleb

  • Caleb Connolly added 3 commits

    added 3 commits

    • 6867073f - test: parse: add tests for bootimg parsing (MR 2477)
    • f5bf9165 - test: aportgen: test deviceinfo fastboot content (MR 2477)
    • 5025aa05 - test: conftest: require_programs() automatically

    Compare with previous version

  • Caleb Connolly added 7 commits

    added 7 commits

    • 5025aa05...472726a9 - 2 commits from branch master
    • 6a5c63a5 - Revert "CI: Add bootimg analysis integration test (MR 2467)"
    • 79079869 - test: conftest: adjust pmaports fixture (MR 2477)
    • 2a2b0057 - test: parse: add tests for bootimg parsing (MR 2477)
    • 0ba0ed53 - test: aportgen: test deviceinfo fastboot content (MR 2477)
    • 9ede556f - test: conftest: require_programs() automatically

    Compare with previous version

    Toggle commit list
  • Oliver Smith added 23 commits

    added 23 commits

    • 9ede556f...7b0db9f8 - 18 commits from branch master
    • 1131db21 - Revert "CI: Add bootimg analysis integration test (MR 2467)" (MR 2483)
    • 39a696ce - test: conftest: adjust pmaports fixture (MR 2477) (MR 2483)
    • f090e861 - test: parse: add tests for bootimg parsing (MR 2477) (MR 2483)
    • cefe98fb - test: aportgen: test deviceinfo fastboot content (MR 2477) (MR 2483)
    • bb126097 - test: conftest: require_programs() automatically (MR 2483)

    Compare with previous version

    Toggle commit list
  • Oliver Smith approved this merge request

    approved this merge request

  • Oliver Smith resolved all threads

    resolved all threads

  • Oliver Smith enabled an automatic merge when all merge checks for bb126097 pass

    enabled an automatic merge when all merge checks for bb126097 pass

  • Oliver Smith merged

    merged

    • Please register or sign in to reply