F901 [*] `raise NotImplemented` should be `raise NotImplementedError`

> NotImplemented is an exception used by binary special methods to
> indicate that an operation is not implemented with respect to a
> particular type.
>
> NotImplemented should not be raised directly. Instead, raise
> NotImplementedError, which is used to indicate that the method is
> abstract or not implemented in the derived class.

Luca Weiss authored 1 year ago and Oliver Smith committed 1 year ago

Taken from https://github.com/torvalds/linux/blob/v6.5-rc7/arch/arm64/include/asm/cputype.h#L65-L86

A user in the unofficial postmarketOS Telegram group was having issues
with their themes and icons not being detected, and the problem was that
they had installed them to these directories, which while arguably ugly
given that they pollute the home directory's top-level namespace,
clearly are used by some users. As such, let's support them in addition
to the other paths.

The setting actually has 3 settings with 3 different behaviors but
gnome control center only exposes "dark" and "default". This lists
all three options.

This avoids having a window inside the TweaksWindow and has makes
sure the application starts and closes correctly

This provides support for the new global dark-style preference
that is honoured by both GTK4 and libadwaita.

This simplifies the Application startup

GTK3 and GTK4 have the themes embedded and do not exist under
/usr/share/themes. Before, they were due to gnome-themes-extra,
but since [1] that is no longer the case. This allows to use the
actual themes and not be overriden by a deprecated one.

[1] https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/40582

.appdata.xml is the old extension. .metainfo.xml is the new
recommended one. It was already being installed into the metainfo
directory, so let's change the extension too.

The icon when the app is running in phosh is missing. This is due
to an issue in gtk3[1]. This has caused problems in other apps, but
Purism did a workaround by using dbus names[2][3]. However, as
this tweaks application does not use dbus, the workaround in phosh
isn't really working. As tweaks is not a cli application, setting
prgname as the applicattion id should not really be an issue.

[1] https://gitlab.gnome.org/GNOME/gtk/-/issues/2822
[2] https://source.puri.sm/Librem5/OS-issues/-/issues/224
[3] https://gitlab.gnome.org/World/Phosh/phoc/-/merge_requests/282