Stop adding merge request ID to commit messages?
The information is tracked automatically by GitLab on each commit:
(the bottom box)
Referencing the MR ID in each commit creates unnecessary noise in MRs IMO (especially if it is added early, like in https://gitlab.com/postmarketOS/pmaports/-/merge_requests/1123), all the "mentioned in commit" here:
This is especially weird because these messages tend to appear again even after the MR was merged (maybe because someone pushed the commit to another branch or something). E.g. if you look at "Last updated", "merged" MRs you can find some updated that were already merged a while ago, e.g. in https://gitlab.com/postmarketOS/pmaports/-/merge_requests/1095:
I tend to use the "Last updated" view as some kind of "notification replacement" (email notifications are too noisy imo), so it's quite annoying if stuff without changes shows up there.
I wonder how useful it is to have the MR ID in each commit:
- if you are browsing in the web-UI you can directly use GitLab's MR link
- explanations should be copied/made directly in the commit message (if this is not always the case already we need to make this more strict...)
- if you want to see related discussion then you can just check the linked MR of the commit in the GitLab Web UI
An alternative to avoid at least all the noise GitLab produces when referencing the MRs would be to drop the !
in front of the MR id, then GitLab wouldn't treat it as reference to the MR anymore.