Notification LED is always blinking during inhibit

added device-pine64-pinephone help wanted release-edge type::bug ui-phosh labels

changed the description

By Oliver Smith on 2021-06-06T15:40:11

By Oliver Smith on 2021-06-06T15:42:21

This shouldn't be the case ;) The notification LED is turned off here, right before suspending. Except if you have an text, e-mail, etc.

I fixed that a while ago: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/merge_requests/222 and was merged into 40.0 which is used at Alpine.

By Dylan Van Assche on 2021-06-06T15:46:20

Oh interesting, thanks!

I'll run feedbackd with debug output to figure out what causes the LED to blink when I find time: https://wiki.postmarketos.org/wiki/Kernel_upgrade_testing#LEDs

By Oliver Smith on 2021-06-06T16:09:06

removed help wanted label

As I wrote, I need to analyze this with feedbackd. However, this is the notification I see (and which doesn't make much sense for phones):

By Oliver Smith on 2021-06-06T16:49:03

Yes, that notification will be visible, but it is closed right before the phone suspend with my patch :) If everything is set up correctly, the notification blinking should come from another source

By Dylan Van Assche on 2021-06-06T16:49:03

I have this behaviour when a process is preventing suspend.

A way to replicate is to plug the phone to a computer, start a ssh session and unplug the USB cable.

By Bobby The Builder on 2021-06-09T17:20:50

True :) What it may cause this behavior @ollieparanoid describes is the following:

Block suspend (by anything that using sleep inhibitor locks)
Release suspend block (app stops, SSH session ended, etc.)
LED keeps blinking until somebody interacts with the device

That another GNOME Settings Daemon bug: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/issues/591 I haven't found a fix for this one, if anyone can fix this, that would be GREAT!

By Dylan Van Assche on 2021-06-09T17:35:10

Thanks for linking this, I didn't know about that bug.

FWIW I should rarely hit this, because my main use case where this is relevant is listening to podcasts, and there the media player runs until I press pause in the UI. Then the inhibitor (alsa play) goes away, but I did give input, so the restart timer should start from there.

Nevertheless, this should be fixed. I looked at the logind api... I guess easiest would be if Suspend() was a boolean that returned if it worked or not and then you could set another timer based on that. The api docs there don't explain the return type (or I don't see it). So either that or set a new timer right after running Suspend() that tries again if expired, and let that timer expire with PrepareForSleep(). So in case of proper suspend, it should get disabled right away. I didn't read related code, this is just my interpretation from the API docs if somebody wants to try it.

By Oliver Smith on 2021-06-10T20:44:38

I've payed some more attention to this issue, and in fact, when the phone is suspending, the LED is not blinking from the suspend message.

What I'm running into frequently is:

media player running with screen off (listen to podcasts)
suspend is prevented
after ~ 1 minute the suspend notification causes the LED to blink
so this blinking is a bit annoying, since there is no new message and it's just always blinking when listening to media with screen off

I wonder if we can completely disable the suspend notification. As I wrote, I don't think it has much value on phones, and with the use case above it's more annoying than useful.

By Oliver Smith on 2021-06-11T06:35:09

2 options:

As soon as Phosh gets notification configuration support (see GNOME Control Center > Notifications), we can suppress the notification.
Create a patch which allow us to remove the the notification completely, not sure if we can upstream this.

I'm in favor of 1 since that's already there, we just need Phosh to implement the interfaces to control them and we can use the same gnome-settings-daemon on all kinds of devices, just shipping a config on phones to disable this notification.

By Dylan Van Assche on 2021-06-11T06:35:09

I think that having a visual feedback to know the phone isn't suspended due to inhibition is a good feature.

However having a blue blinking LED is confusing; as Oliver said it could mean you have received a SMS.

Allow me to pitch a third option:

Would it be possible to keep the notification with a different color ?

I remember back in the days when I owned a BlackBerry it had a different LED color when you had an unread e-mail, SMS, MMS ...

By Bobby The Builder on 2021-06-11T21:52:52

Would it be possible to keep the notification with a different color ?

I think this is unintuitive and should be something users enable themselves if they want it. Many people probably don't understand the difference between the phone being inhibited and suspended. In addition to that, it won't work on all devices as some have single-coloured leds, or only two colours, or such. Maybe this could be something users can set up via postmarketOS Tweaks?

By Newbyte on 2021-06-12T07:39:27

I think this is unintuitive and should be something users enable themselves if they want it

I don't like that notification at all, I find it annoying on a phone. I would rather get rid of it as not a single phone has the behavior.

Would it be possible to keep the notification with a different color ?

Feedbackd is the place where to look for this. However, this is marked as a regular notification so all regular notifications are visualized then like this.

By Dylan Van Assche on 2021-06-12T10:53:18

I don't like that notification at all, I find it annoying on a phone. I would rather get rid of it as not a single phone has the behavior.

I just pushed a MR request upstream with what I thought would be a sensible solution: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/merge_requests/285 Let's see if maintainers agree and we could get this fixed :)

By Pablo Correa Gomez on 2022-02-05T18:16:50

I wonder if we can completely disable the suspend notification. As I wrote, I don't think it has much value on phones, and with the use case above it's more annoying than useful.

I don't like that notification at all, I find it annoying on a phone. I would rather get rid of it as not a single phone has the behavior.

I would personally like the notification to still appear. I'm often looking at my phone, say staring at a browser showing GPS updates while waiting for a delivery, and when the notification pops up it reminds me to touch somewhere to reset the sleep timer. If the phone suspended without the notification I would be annoyed.

If there's a way to have the notification appear but not trigger the flashing LED, that would be best for everyone, I think.

Just my 2c. I'll be fine with re-enabling the setting that https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/merge_requests/285 is adding if it comes to that.

By Arnav Singh on 2022-07-26T02:33:09

changed title from Notification LED is always blinking during suspend (crust) to Notification LED is always blinking during inhibit

By Oliver Smith on 2021-06-10T20:46:48

changed the description

By Oliver Smith on 2021-06-10T20:46:48

mentioned in issue #1434 (closed)

By Newbyte on 2022-02-22T10:16:05

Closing issue due to inactivity.

By Robert Eckelmann on 2024-08-14T14:26:03

closed

Notification LED is always blinking during inhibit

Describe your issue

What's the expected behaviour?

What's the current behaviour?

How to reproduce your issue?

What device are you using?

On what postmarketOS version did you encounter the issue?

On what environment did you encounter the issue?

Phone environments

How did you get postmarketOS image?

Child items ...

Activity