refactor: udev rule package for tm2-touchkey

changed title from Feature request: main: udev rule package for tm-touchkey to Feature request: udev rule package for tm-touchkey

By Raymond Hackley on 2022-02-10T16:12:14

I would like to work on this tomorrow. How should I name the package and under which directory should I put it?

By Raymond Hackley on 2022-02-10T16:12:55

changed the description

By Raymond Hackley on 2022-02-10T16:15:02

changed the description

By Raymond Hackley on 2022-02-10T16:27:37

cc @Jakko

By Minecrell on 2022-02-10T16:49:45

changed the description

By Raymond Hackley on 2022-02-10T19:11:40

added category::device device-samsung-a5 + 1 deleted label

For the tm2-touchkey LEDs, we install an udev rule lib/udev/rules.d/20-tm2-touchkey-leds.rules by package postmarketos-base [1][2]. This file is installed on all postmarketOS installations. The key KERNEL=="tm2-touchkey" makes sure it is applied only to devices using this driver.

For the key remapping, I didn't dare to install the udev rule /lib/udev/rules.d/20-tm2-touchkey-input.rules on all devices. I expect device-specific variations on the printed labels of the buttons, on the key mapping in the device-tree, on the kernel version, etc.

However, let's assume installing the udev rule file to all devices:

(The current ones in the device packages would need to be removed, of course.)
The udev rule would override the key mapping defined in the device-tree – on all devices [edit: on all devices using tm2-touchkey driver]. I think it's a bit too intrusive. On the other hand, if the key mapping generally makes sense, probably it's reasonable.
The second key would need to be defined in the udev rule as well because we don't know how it's mapped in the device-tree of each device. The udev rule would then need to look like: SUBSYSTEM=="input", KERNEL=="event*", DRIVERS=="tm2-touchkey", ENV{KEYBOARD_KEY_00}="menu", ENV{KEYBOARD_KEY_01}="back", RUN{builtin}+="keyboard". And the comment above that line should be changed to something more general.
On devices using tm2-touchkey driver with kernel version < 5.16 there will be an error line in dmesg and the udev rule remains without effect [3]. Maybe that's acceptable...
I don't know Android very well. In some configurations, the keys are swapped (the "back" key on the left side). And I don't know if there are some devices using tm2-touchkey that have the labels printed the other way around. In that case, the key mapping should be the other way around, too. If this is a rare case, these devices could install an additional udev rule by their device packages, overriding the other one. Overriding can by done by increasing the file name number to e.g. 21-tm2-touchkey-leds.rules.

Summing everything up, I think it's ok to put it into package postmarketos-base. (Modified to define both keys, as described above.)

By Jakko on 2022-02-10T20:49:08

I would like to add that at some future point, the key "menu" could be changed back to "appselect" for some Wayland user interfaces. This would be the correct key for Android (e.g. when using waydroid in full screen). Currently neither in Phosh nor in Plasma Mobile the "appselect" key is handled entirely correctly.

Placing the udev rule to package postmarketos-base makes such UI-dependent installation cases more comlicated or hindering. Still I suggest to install it to postmarketos-base, as I don't expect this "appselect" key handling being solved any time soon in Phosh or Plasma Mobile.

By Jakko on 2022-02-10T20:50:04

How about !2926?

By Raymond Hackley on 2022-02-12T07:23:12

Looks good in general! I added a comment to map both keys.

By Jakko on 2022-02-12T11:30:35

changed title from Feature request: udev rule package for tm-touchkey to refactor: udev rule package for tm2-touchkey

By Raymond Hackley on 2022-02-12T07:54:20

changed the description

By Raymond Hackley on 2022-02-12T07:55:32

closed with commit 9833cc8a

closed

mentioned in commit 9833cc8a

By Raymond Hackley on 2022-03-04T23:21:40

Hi all,

I know this is closed, and am grateful my touchkeys have started working (samsung-t0lte), but the midas devices (Exynos4 S3 and Note 2 devices) use the same driver, but have a hardware variant of the main tm2 touchkey, which accounted for in the driver (https://github.com/torvalds/linux/blob/master/drivers/input/keyboard/tm2-touchkey.c#L57-L84). As such my keys are reversed, so that back is menu and menu is back. Can the udev rule be rewritten to account for my different compatible in the midas device tree (https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/exynos4412-midas.dtsi#L243)?

Thanks a lot,

Jack K

By Jack K on 2022-06-05T15:56:49

This ought to work, no?

# map tm2-touchkey to KEY_MENU and KEY_BACK (main variant)
SUBSYSTEM=="input", KERNEL=="event*", DRIVERS=="tm2-touchkey", ATTRS{name}!="midas-touchkey", \
ENV{KEYBOARD_KEY_00}="menu", ENV{KEYBOARD_KEY_01}="back", RUN{builtin}+="keyboard"

# map tm2-touchkey to KEY_MENU and KEY_BACK (midas variant)
SUBSYSTEM=="input", KERNEL=="event*", DRIVERS=="tm2-touchkey", ATTRS{name}=="midas-touchkey", \
ENV{KEYBOARD_KEY_01}="menu", ENV{KEYBOARD_KEY_00}="back", RUN{builtin}+="keyboard"

By Jack K on 2022-06-05T15:56:49

mentioned in merge request !3192 (merged)

By Jack K on 2022-06-05T18:32:06

refactor: udev rule package for tm2-touchkey

Describe your issue

What's the expected behaviour?

What's the current behaviour?

How to reproduce your issue?

What device are you using?

On what postmarketOS version did you encounter the issue?

On what environment did you encounter the issue?

Phone environments

Other

How did you get postmarketOS image?

What's the build date of the image? (in yyyy-mm-dd format)

Additional information

Child items ...

Activity