CI check for kconfig check outputs unrelated entries
What's the expected behaviour?
The CI check for the kernel config (runs pmbootstrap kconfig check
) doesn't print warnings by default. Meaning if you change a kernel and kconfig check fails, you will directly see the relevant options you need to change in your kernel config and not unrelated messages for other kernels you did not change.
What's the current behaviour?
unrelated warnings from linux-google-veyron and linux-postmarketos-qcom-msm8998
The reason that these unrelated warnings show up is: both kernels have pmb:kconfigcheck-community
in their APKBUILD options, but they are devices in the testing category. Since this patch we allow this (only devices in main and community fail there, devices in testing that have the option set don't fail).
I thought it was fine at the time, but thinking some more about it, the unrelated warnings it generates aren't great.
I think we should fix this / our workflow by adjusting the kernels in testing category that have pmb:kconfigcheck-community
set too whenever we change the required kernel options. IMHO the effort is reasonable because:
- right now it's only 3 kernels
- IMHO it's useful to set this for testing kernels too to make them more consistent, and to get them ready towards moving to community - especially for close to mainline kernels
- if a kernel doesn't build after changing the options or if it's not reasonable to adjust a particular kernel for another reason, we can ping the maintainer and if they don't have time, we can remove
pmb:kconfigcheck-community
until they fix it and add it again
Furthermore I think we should revert the pmbootstrap patch once we have done this, so we don't get the unrelated warnings anymore and have the kernels a bit more consistent.
Last but not least this will be much easier once implementing pmbootstrap#2190.
An alternative solution to this problem would be only checking the kernels that were modified. But I don't like this approach much, as then we may forget to change kernel configs after changing the requirements and may not notice it for some time. Doing it as described above will make sure that we have the kernel configs consistent most/all of the time, and if we don't, we will catch it immediately and fix it.
CC: @z3ntu, @minlexx, @craftyguy, @Newbyte (we discussed this lately in the chat)