Add adaptive patches to GTK4
Purism has some adaptive patches to GTK4 which improve the user experience on mobile (mostly the transient window handling). I think these would be nice to have in postmarketOS as well.
Activity
Do you have any opinion on how we should handle this @pabloyoyoista? I'm not too keen on forking GTK 4 to pmaports, but I am not sure we want to carry patches like this in aports either.
Either way, thanks for letting us know about this. I wasn't aware.
By Newbyte on 2023-02-19T22:20:14
Edited by Administrator-
This is cool, but forking a core library in pmOS without a clear temporal plan for its removal is a problem that has already bitten us in the past (e.g: we had huge issues updating and building the GTK3 fork). Thinks should go upstream, or should be in a state were upstreaming them is possible. @psykose already mentioned a reason why they are not upstreamable, but I will add that they add a gsetting which changes the configuration for phones. And selection based on it works, but is a temporary hack. Therefore, those patches are nowhere near being upstreamable :(
Unless there is someone committing their time and effort to keep the downstream version updated and work in the patches to get them in an upstreamable form, I would be strongly against it (though I cannot veto it
By Pablo Correa Gomez on 2023-02-19T22:20:14
-
if they were already upstreamed changes that cleanly applied in a backport onto 4.8 or something, i'd be more than happy to have a backport that is just "better support for some devices" :/
of course, this really isn't that, it's just downstream (librem) specifics, which is unfortunate.
we had huge issues updating and building the GTK3 fork
something else that you can do on top of pkgver=9999, is to patch the soversion to make the minor 999 too (i.e. .so.4.999.0), it's one line in meson somewhere. that version is also considered iirc.
with that, it should work (with the same pkg/subpkg names). i've tested that myself in various ways. of course, if something goes astray, debugging it isn't easy :D
By psykose on 2023-02-20T12:49:01
Edited by Administrator -
something else that you can do on top of pkgver=9999, is to patch the soversion to make the minor 999 too (i.e. .so.4.999.0), it's one line in meson somewhere. that version is also considered iirc.
There's more to it than that. Purism's patches don't always apply cleanly on top of the latest upstream GTK, which means we stray further from upstream by delaying updates until they're rebased. And also sometimes means it stops building because some other thing changed.
By Newbyte on 2023-02-20T12:51:03
Edited by Administrator
added type::feature label