Skip to content
Snippets Groups Projects
New look: Off

Remove instances of wallpaper definitions in device packages

    • Open Imported Issue created by Administrator @root

    The what

    I removed the bulk of these with !4713 (closed), but there are still instances where this happens which are less trivial to remove:

    • device-xiaomi-willow-weston

    Uses a downstream kernel, but the commit message (ffcc6acd) claims that "Weston on DRM" works and that fbdev is broken. I'm not sure how this could be, but I feel hesitant to straight up remove the config (where the wallpaper is defined as well) given that it includes some workarounds apart from setting the DRM backend. Could there be some way of only removing the wallpaper definition from here while retaining the other configuration options?

    @rjeli would you still be available for testing Weston again on this device?

    • device-oneplus-kebab-weston

    Similar story as xiaomi-willow. While the commit message doesn't say much, there is a comment in the -weston subpackage that says "weston use drm backend, 2x dpi, don't use virtual output", which sounds like whoever authored it had Weston successfully running with the DRM backend despite it using a downstream kernel.

    @afeuerstein would you still be available for testing Weston again on this device?

    • device-pine64-pinetab-weston

    This device actually uses mainline and should have working DRM, but the Weston configuration applies a transform onto the output. I assume this is because the panel needed some rotation applied to display at the right orientation at the time of creating the configuration. Would be great if someone could test if this still is the case.

    @minlexx, @MartijnBraam, @z3ntu, @danct12 would one of you be able to test this? I don't have an original PineTab to test on.

    There is also the N900, but it effectively has its own UI package inside the device package, which is a whole different beast to tackle and probably not a big deal for this purpose.

    The why

    We plan to switch wallpapers with every release now that we have someone who's happy to make wallpapers for us (see #2499 (closed)). As it is right now, if we want to change the wallpaper, we have to perform shotgun surgery not only across the UI packages but also various device packages. !4713 (closed) reduced this significantly, but ridding ourselves of this entirely would be preferable.

    0 of 3 checklist items completed
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    Please register or sign in to reply