linux-postmarketos-omap fails to mount vfat boot

Describe your issue

if /boot is fat32, initfs fails to mount it

What's the expected behaviour?

/boot gets mounted

What's the current behaviour?

mount fails because of iocharset=ascii is not there: CONFIG_NLS_ASCII is not set

FAT-fs (mmcblk0p1): IO charset ascii not found

btw: mounting without any options works (so without iocharset=ascii)!

How to reproduce your issue?

have /boot as fat32 (deviceinfo_boot_filesystem="fat32") with linux-postmarketos-omap kernel

On what postmarketOS version did you encounter the issue?

• edge (master branch)

• v23.12

• v24.06

• I confirm that the issue still is present after running sudo apk upgrade -a

On what environment did you encounter the issue?

Environments

• GNOME Shell on Mobile
• Phosh
• Plasma Mobile
• Sxmo (Wayland/Sway) Please post the output of sxmo_version.sh
• Other: Please fill out

How did you get postmarketOS image?

• from https://images.postmarketos.org
• I built it using pmbootstrap
• It was preinstalled on my device

What's the build date of the image? (in yyyy-mm-dd format)

Additional information

CONFIG_NLS_ASCII: Should be CI checked for community kernels?

added type::bug label

assigned to @MightyM17

By Andreas Kemnade on 2024-06-07T08:06:48

added ci device-category::community labels

changed the description

By Andreas Kemnade on 2024-06-07T08:30:23

changed the description

By Andreas Kemnade on 2024-06-07T08:31:08

So we need to enable CONFIG_NLS_ASCII in the config for it to work?

By Mighty on 2024-06-07T09:05:02

either that or no iocharset specified by the mount in initramfs. We have

    echo "Detected vfat filesystem"
                        modprobe vfat
                        mount_opts="-t vfat $mount_opts,umask=0077,nosymfollow,codepage=437,iocharset=ascii"

in mount_boot_partition in /init_functions.sh.

I am wondering whether we should add that to CI checking for community kernels.

By Andreas Kemnade on 2024-06-07T11:02:40

Yep pmos kconfig check should add it, well a MR can be sent once we confirm that this fixes it :D

By Mighty on 2024-06-07T11:02:08

--- a/device/community/linux-postmarketos-omap/config-postmarketos-omap.armv7
+++ b/device/community/linux-postmarketos-omap/config-postmarketos-omap.armv7
@@ -7245,7 +7245,7 @@ CONFIG_NLS_CODEPAGE_437=y
 # CONFIG_NLS_ISO8859_8 is not set
 # CONFIG_NLS_CODEPAGE_1250 is not set
 # CONFIG_NLS_CODEPAGE_1251 is not set
-# CONFIG_NLS_ASCII is not set
+CONFIG_NLS_ASCII=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_NLS_ISO8859_2 is not set
 # CONFIG_NLS_ISO8859_3 is not set

indeed fixes it.

By Andreas Kemnade on 2024-06-07T14:15:37

Amazing! Could you send a MR for the same, I'll do it if you're busy.

By Mighty on 2024-06-08T09:33:17

this issue is instroduced by !5089 (merged)

By Andreas Kemnade on 2024-06-07T11:02:43

mentioned in issue #2782

By Andreas Kemnade on 2024-06-07T10:12:52

i would guess pmos will want to add a kconfig check for this...

in meantime, @akemnade want to submit an MR against linux-postmarketos-omap?

By Sicelo on 2024-06-07T10:59:47

I'm still waiting for #2825 (closed) to get resolved before getting r1 for the kernel. We might need to debug more on the patches for clk and system-power-controller

By Mighty on 2024-06-07T10:59:47

mentioned in merge request !5216 (merged)

By Mighty on 2024-06-08T12:43:27

mentioned in commit c9a1b901

By Mighty on 2024-06-10T17:59:22

closed

mentioned in merge request !5301 (merged)

By Arnav Singh on 2024-07-04T23:54:10

mentioned in merge request !5545 (merged)

By Robert Eckelmann on 2024-08-31T12:32:18