generic-x86_64: mkinitfs fails if i915 firmware is not installed
Describe your issue
What's the expected behaviour?
mkinitfs
works
What's the current behaviour?
13:28:45.117879 -- Including files from: /usr/share/mkinitfs/files/30-gpu-firmware.files
13:28:45.117907 hookfiles: unable to process hook file "/usr/share/mkinitfs/files/30-gpu-firmware.files": unable to add "/lib/firmware/i915": getFile: failed to stat file "/lib/firmware/i915": stat /lib/firmware/i915: no such file or directory (also tried "/lib/firmware/i915.zst": stat /lib/firmware/i915.zst: no such file or directory)
and then it aborts
How to reproduce your issue?
mkinitfs
without i915 firmware installed
What device are you using?
generic-x86_64
On what postmarketOS version did you encounter the issue?
-
edge ( master
branch) -
v24.06
-
I confirm that the issue still is present after running sudo apk upgrade -a
Additional information
This is a regression from !5527 (merged).
Workaround: sudo rm /usr/share/mkinitfs/files/30-gpu-firmware.files
@craftyguy: I guess the best fix would be renaming it to 30-gpu-firmware-i915.files
and only installing it conditionally if the firmware is actually present, with install_if
?