PinePhone: automatically use the right dts in u-boot

@z3ntu wrote in !1143 (comment 322072564):

We also have to think about how we're going to handle the different revisions in the future. I would really dislike to have multiple copies of the pinephone in pmaports just because they need different dtbs to boot.

@DolphinChips wrote:

How about keeping the same package for different revisions but making u-boot script somehow understand what revision of Pinephone it's dealing with and selecting dtb based on that information?

@MartijnBraam wrote:

No the hardware itself has no way to identify the different board revisions sadly

@Minecrell wrote:

If no special handling is needed yet, then we should tell PINE64 to add a way to identify newer revisions in the future. That's what feedback is for IMO :)

changed milestone to %[device] PinePhone support

added discussion help wanted labels

mentioned in merge request !1143 (merged)

By Oliver Smith on 2020-04-18T16:55:24

Just an FYI, u-boot can be configured to automatically pick the right DTB, under the option CONFIG_MULTI_DTB_FIT which requires a function called board_fit_config_name_match. Couple this with an extlinux.conf file instead of a uboot-script.cmd and it works quite nicely (I have this on the first-gen Galaxy S devices to support multiple variants, which I should really upstream one of these days... We do it based on external pull-ups being connected to different GPIOs).

Of course, this presumes there's some way of figuring out which boards are which, and that seems to be a problem :)

By Jonathan Bakker on 2020-04-19T01:10:14

Also relevant:

@ollieparanoid wrote:

Still unclear: do we need to keep the previous dtb version around for some devices, or do all currently available revisions work with 1.1?

@MartijnBraam wrote:

well sun50i-a64-pinephone.dtb just doesn't exist anymore. there's pinephone-1.0 (dev batch) and pinephone 1.1 (braveheart batch). In these two versions there aren't really big issues but the 1.2 (ubuntu CE) has some things hooked up differently so we need a way to use the right dtb then. Ideally by having all the dtbs in /boot and having u-boot figure it out.

@z3ntu wrote:

We need to get postmarketos-mkinitfs to copy multiple dtb files then as a first step.

By Bart Ribbers on 2020-04-22T10:05:54

Fixed by !1163 (merged)

By Oliver Smith on 2020-07-16T21:47:17

closed