phosh: switch from "playing hi-fi music" and "make a call" automatically

When a call is placed, phosh should automatically switch to the make a call configuration of audio. Without this, users make mistakenly believe that the audio calls are broken.

This behavior is supported in debian+phosh. Im currently doing research into what they are doing differently.

Related: #497 (closed)

According to debian+phosh's README, they are compiling alot of their packages from purism's fork. That is understandable as alot of the changes have not been accepted upstream similar to geary in #459 (closed).

In relation to this issue, purism has done extensive work with Dynamically manage audio routing:

https://source.puri.sm/Librem5/OS-issues/issues/104

I don't know how purism and debian implemented it but I was thinking this could be implemented using feedbackd. When a call comes in, the phone-incoming-call event is triggered by feedbackd (https://source.puri.sm/Librem5/feedbackd/blob/master/Event-naming-spec-0.0.0.md). When that event is triggered we switch to "make phone call" audio profile. What do you guys think?

By Anjandev Momi on 2020-04-22T06:29:42

added type::feature ui-phosh labels

CC @MartijnBraam and @Cogitri

By Bart Ribbers on 2020-04-22T08:29:08

According to debian+phosh's README, they are compiling alot of their packages from purism's fork. That is understandable as alot of the changes have not been accepted upstream similar to geary in #459 (closed).

Well, the best solution would be to get those upstream ASAP but I guess most things would only land in GNOME 3.38 now, so in the meantime pmOS will probably have to use some of the forks (since those won't get into Alpine).

When that event is triggered we switch to "make phone call" audio profile. What do you guys think?

Hm, not sure how we'd do that switch. I guess we should update feedbackd though, I'll look into that.

By Rasmus Thomsen on 2020-04-22T09:05:14

(since those won't get into Alpine).

Wait, 3.38 won't get into Alpine? That's a stable release no? Why would Alpine not get it?

By Bart Ribbers on 2020-04-22T10:37:35

Ah sorry that I was unclear, I didn't mean 3.38 won't get into Alpine. I meant that we won't use the forks in Alpine, since that:

• We'd have to review those changes if Upstream hasn't done so.
• Accept bug reports that only apply against the fork and not against the upstream project (and as such probably no help from upstream).

Since GNOME 3.38 is expected to land on September 12 it should get into Alpine 3.13, so it'd be in a stable release in ~November.

By Rasmus Thomsen on 2020-04-22T11:07:16

afaik the debian build just has a shell script that waits on a call event on dbus and switches the pulse output

By Martijn Braam on 2020-04-22T22:30:10

According to the debian+phosh wiki, here's how they did it:

calls

Voice calls application.

Modifed to use the PinePhone's audio device name for switching to Speaker output, and replaced the "Add Call" button with a "Headset" button, switching to headphone + headset mic during a call (can be removed when jack insertion detection is implemented in driver sun50i-codec-analog, if it ever happens). None of these changes can be upstreamed.

Forked from Purism.

Should be packaged for Debian.

The source code is here: https://gitlab.com/a-wai/calls

Source: https://gitlab.com/a-wai/debos-pinephone/-/wikis/Software

By Anjandev Momi on 2020-04-22T23:39:53

Thanks for opening this issue, and for all the information that has been contributed.

I did not realize that we have two issues for this already. Closing this one in favor of the newer one: #644 (closed)

(Note that a MR is open to have a separate package with mobian's patched wys, until this is upstreamed properly: !1406 (merged). Please continue the discussion in #644 (closed).)

By Oliver Smith on 2020-07-11T10:34:22

closed

By Oliver Smith on 2020-07-11T10:34:23

added 1 deleted label

removed type::feature ui-phosh labels

added status::duplicate label