pine64-pinephone: add uinput module into initramfs for early fbkeyboard support

Needed by !1094 (merged)

mentioned in merge request !1094 (merged)

By Ferenc Bakonyi on 2020-03-24T18:04:55

Good, but this can also be added to PineTab's device package, imo

By Alexey Min on 2020-03-24T18:13:57

I think we should add something to allow initramfs hook to request modules to be included (similar to console-shell.files in !1094 (merged)). This really shouldn't be separately in each device package IMO.

By Minecrell on 2020-03-24T18:51:15

added category::device type::feature labels

@Minecrell Btw some configs in mainline use CONFIG_INPUT_UINPUT=y instead of =m

arch/arm/configs/colibri_pxa270_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/corgi_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/ezx_defconfig:CONFIG_INPUT_UINPUT=y
arch/arm/configs/imote2_defconfig:CONFIG_INPUT_UINPUT=y
arch/arm/configs/magician_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/netwinder_defconfig:CONFIG_INPUT_UINPUT=y
arch/arm/configs/omap1_defconfig:CONFIG_INPUT_UINPUT=y
arch/arm/configs/omap2plus_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/pxa_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/qcom_defconfig:CONFIG_INPUT_UINPUT=y
arch/arm/configs/s3c2410_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/spitz_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/trizeps4_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/viper_defconfig:CONFIG_INPUT_UINPUT=m
arch/arm/configs/zeus_defconfig:CONFIG_INPUT_UINPUT=m
arch/mips/configs/db1xxx_defconfig:CONFIG_INPUT_UINPUT=y
arch/mips/configs/loongson3_defconfig:CONFIG_INPUT_UINPUT=m
arch/parisc/configs/generic-32bit_defconfig:CONFIG_INPUT_UINPUT=m
arch/powerpc/configs/amigaone_defconfig:CONFIG_INPUT_UINPUT=y
arch/powerpc/configs/chrp32_defconfig:CONFIG_INPUT_UINPUT=y
arch/powerpc/configs/linkstation_defconfig:CONFIG_INPUT_UINPUT=m
arch/powerpc/configs/ppc6xx_defconfig:CONFIG_INPUT_UINPUT=m
arch/powerpc/configs/wii_defconfig:CONFIG_INPUT_UINPUT=y

So these modules have to be optional (compared to the ones specified in deviceinfo) imo

By Luca Weiss on 2020-03-29T07:52:14

The modules in deviceinfo are optional AFAIK.

By Minecrell on 2020-03-29T07:52:14

They are optional, modprobe will complain here if these modules do not exist:

https://gitlab.postmarketos.org/postmarketos/pmaports/-/blob/34061fed2d34b044250656b5c21ef76ccd943756/main/postmarketos-mkinitfs/mkinitfs.sh#L80

(Which may not be the nicest solution, but this is how it is now.)

By Oliver Smith on 2020-04-04T14:09:58

mentioned in merge request !1123 (merged)

By Oliver Smith on 2020-04-04T14:08:05

@Minecrell wrote:

I think we should add something to allow initramfs hook to request modules to be included (similar to console-shell.files in !1094 (merged)). This really shouldn't be separately in each device package IMO.

Well, I agree. In order to move this forward (the fbkeyboard related MRs have been around for a while now... thanks for your patience @bakonyi.ferenc!), I've created MR !1123 (merged) to enable initramfs hooks to list modules that should be included. After it is merged, we can have a console-shell.modules file, that adds uinput.

By Oliver Smith on 2020-04-04T14:09:56

Thank you all for supporting this! Closing this MR now.

By Ferenc Bakonyi on 2020-04-12T18:48:10

closed

By Ferenc Bakonyi on 2020-04-12T18:48:10