xiaomi-santoni: moving to community
Because it met the requirements for a community port.
Merge request reports
Activity
added category::device label
added 3 commits
-
7692f1df...995af7fb - 2 commits from branch
postmarketOS:master - c9972d85 - xiaomi-santoni: moving to community
By Danct12 on 2020-05-08T08:38:48
-
7692f1df...995af7fb - 2 commits from branch
Looks like a good port to me!
In
device-xiaomi-santoni-nonfree-firmware.post-install:#!/bin/sh # We make sure that tsched has not mentioned anywhere in the default PulseAudio config if [ "$(grep -c tsched /etc/pulse/default.pa)" -lt "1" ]; then sed -i 's/load-module module-udev-detect/load-module module-udev-detect tsched=0/g' /etc/pulse/default.pa fi- The comment is misleading, the code adds tsched=0 if it is missing. It sounds from the comment like it would be removed.
- The if condition could be refactored to
if grep -q tsched /etc/pulse/default.pa; then
Besides that, I'd give my approval (you need four).
By Oliver Smith on 2020-05-17T11:47:27
added 35 commits
-
c9972d85...df3196f5 - 33 commits from branch
postmarketOS:master - 74c5b4b0 - device-xiaomi-santoni: refactored nonfree-firmware post install script
- 11a3fd41 - xiaomi-santoni: moving to community
By Danct12 on 2020-05-17T12:19:21
-
c9972d85...df3196f5 - 33 commits from branch
added 92 commits
-
a7815463...5aababed - 90 commits from branch
postmarketOS:master - e67ca8f7 - device-xiaomi-santoni: enable swclock
- 586dc07c - *-xiaomi-santoni: fix audio distortion with tsched
By Danct12 on 2020-06-11T12:48:38
-
a7815463...5aababed - 90 commits from branch
added 5 commits
-
35f94b57...057fa02f - 2 commits from branch
postmarketOS:master - 97b150df - device-xiaomi-santoni: enable swclock
- c9712925 - *-xiaomi-santoni: fix audio distortion with tsched
- 183ef0d8 - xiaomi-santoni: move to community
By Danct12 on 2020-06-11T12:55:53
Toggle commit list-
35f94b57...057fa02f - 2 commits from branch
added 1 commit
- 921c3417 - linux-xiaomi-santoni: add description to mdss_fb patch
By Danct12 on 2020-06-11T16:09:23
-
Hi @danct12,
Thanks a lot for opening this MR, and especially all your work on this device port! I can see that there was a lot of work put into this device port, and it's definitely one of the best working ports using a downstream kernel at the moment.
When I suggested introducing device categories in https://gitlab.com/postmarketOS/postmarketos/-/issues/16 my primary goal was to improve visibility that could be almost in
main(officially recommended devices that are basically fully working and usable), but there are some complicated bits missing to make them fully working. Each device is different, and often one particular feature is harder to get working than others (e.g. camera or GPU). That's why I tried to avoid adding a fixed set of required functionality for community.From a different perspective, the purpose of community is the following: For most of the functionality it shouldn't make much of a difference if you buy a device from
mainorcommunity. A smartphone in community should work largely the same as a smartphone in main (e.g. hopefully the PinePhone soon), there are just a few more limitations you need to live with. Obviously a tablet, SBC or the N900 due to its age and special format have different requirements (based on their intended usage with postmarketOS).There isn't any requirement for a (close-to) mainline kernel for community, on purpose: Certainly, with enough work functionality can be made working on both downstream and mainline kernels:
- Downstream kernels are usually easier to get started with, but at some point you hit a wall where making special functionality work becomes much more complicated (e.g. GPU, audio/sensors on some devices).
- Mainline kernels are much harder to get started with, but by design you can usually get certain hardware working more easily (e.g. GPU, sensors).
Overall, I would expect that the effort to reach the state necessary for community is similar for both downstream and mainline, you just spend different amounts of time for certain functionality. I don't want to make any distinction between downstream or mainline at all, what matters is only how functional the device is for postmarketOS.
I tried to fit all that (and more) into the short and concise requirements listed for community on the wiki page, but they are likely not nearly as clear as the long text I have just written.
Overall I'm not entirely sure if xiaomi-santoni is already ready for community. To look at the (short) requirements one by one:
- a lot of work was put into: YES
- are (and stay) working quite well (i.e. they are useful in some way and are tested occasionally to find and fix regressions):
- I have to admit: my formulation "in some way" is rather stupid here. Certainly all ports are useful in some way, even just to show how normal Linux can run on a device, or to motivate other people to continue working on the port.
- Essentially I would expect that you can use it just like the other smartphones in main/community: You can install our mobile UIs like Plasma Mobile or Phosh and they are somewhat usable.
- As far as I understand, this does not work on santoni at the moment, right?
-
are still being improved or are considered completed at some point:
- The "considered completed" is intended for devices like the asus-me176c for example. It's basically fully working, but GPS and Camera are missing because they are really extremely complicated to get working. Nevertheless, everything else can be used just fine.
- To me it looks a bit like you have hit that wall for downstream kernels I was talking about: There is some functionality working, but within the last year it has been somewhat "stuck" in terms of further steps forward.
- are (and stay) overall in good shape: YES
Don't get me wrong, I think the xiaomi-santoni is a great device port. I just think that in it's current state we should make it better visible in other ways, e.g. by reducing visibility for other devices that barely have anything working at all or are unmaintained (and potentially entirely broken at this point).
I also see that there efforts to make mainline work on xiaomi-santoni - that's great! Maybe it's actually easier to make it ready for community that way.
What do you think?
By Minecrell on 2020-06-17T09:15:44
mentioned in issue #703 (closed)
By Antoine Fontaine on 2020-07-30T23:07:52