Skip to content
Snippets Groups Projects

main/linux-postmarketos-allwinner: enable Anbox networking options

Closed Imported Administrator requested to merge anbox-fixes into master
Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    The pkgver needs to be bumped and the MR settings are incorrect, see the CI logs.

    Overall change seems reasonably sane, not sure why ipv6 is changed from module to built in though, a lot of this stuff can and should be modules, iptables probes these when needed and the stuff like ipsec is a huge chunk of code that won't reasonably be used.

    By Martijn Braam on 2020-12-08T16:15:55

  • Administrator added 1 deleted label · Imported

    added 1 deleted label

  • Author Owner

    Please squash the commits into 1 and rename it to "main/linux-postmarketos-allwinner: enable Anbox networking options".

    By Bart Ribbers on 2020-12-09T13:15:28

  • Author Owner

    I have tested it last night and it seems to be working. That's great!

    In order to get this merged, you need to do three things:

    1. update the pkgrel: pmbootstrap pkgrel_bumb linux-postmarketos-allwinner, so that the package will be rebuilt once merged;
    2. update the MR settings so that we can update the branch. It is used to standardize the commit messages, and to sign the commits before merging them.
    3. move the options from built-in (=y) to modules (=m), we try to modularize what can be. (I realize that in the config fragment I sent you, the code was built-in :X)

    Thanks!

    By Antoine Fontaine on 2020-12-09T13:42:23

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By edp17 on 2020-12-13T00:23:20

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By edp17 on 2020-12-13T00:31:28

  • Administrator changed title from #480 - Fix Anbox networking problem to main/linux-postmarketos-allwinner: enable Anbox networking options · Imported

    changed title from #480 - Fix Anbox networking problem to main/linux-postmarketos-allwinner: enable Anbox networking options

    By edp17 on 2020-12-13T00:48:27

  • Administrator changed the description · Imported

    changed the description

    By edp17 on 2020-12-13T00:48:27

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By edp17 on 2020-12-13T01:04:47

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By edp17 on 2020-12-13T01:11:01

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By edp17 on 2020-12-13T01:14:53

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By edp17 on 2020-12-13T01:19:35

  • Author Owner

    Related to postmarketOS/pmbootstrap!2005

    By Luca Weiss on 2020-12-13T16:51:46

  • Administrator changed milestone to %Anbox · Imported

    changed milestone to %Anbox

  • Administrator mentioned in merge request !1337 (closed) · Imported

    mentioned in merge request !1337 (closed)

    By Antoine Fontaine on 2020-12-14T15:31:17

    • Author Owner
      Resolved by Administrator

      @edp17 I think maybe you had a bad rebase, the kernel config in the current rev of this patch does not enable anything new in the kernel:

      diff --git a/main/linux-postmarketos-allwinner/config-postmarketos-allwinner.aarch64 b/main/linux-postmarketos-allwinner/config-postmarketos-allwinner.aarch64
      index 710bca110..1e64a6b90 100644
      --- a/main/linux-postmarketos-allwinner/config-postmarketos-allwinner.aarch64
      +++ b/main/linux-postmarketos-allwinner/config-postmarketos-allwinner.aarch64
      @@ -2,7 +2,7 @@
       # Automatically generated file; DO NOT EDIT.
       # Linux/arm64 5.9.10 Kernel Configuration
       #
      -CONFIG_CC_VERSION_TEXT="gcc (Alpine 10.2.1_pre0) 10.2.1 20201113"
      +CONFIG_CC_VERSION_TEXT="gcc (Alpine 10.2.1_pre1) 10.2.1 20201203"
       CONFIG_CC_IS_GCC=y
       CONFIG_GCC_VERSION=100201
       CONFIG_LD_VERSION=235010000

      This also needs to be rebased on master, the kernel package was recently upgraded to 5.10.

      By clayton craft on 2020-12-15T07:56:17

  • Administrator added 43 commits · Imported

    added 43 commits

    • 7586ae30...64b8f211 - 41 commits from branch postmarketOS:master
    • 04d53be0 - Kernel changes for fixin Anbox networking (edp17)
    • 73c6c910 - main/linux-postmarketos-allwinner: enable Anbox networking options

    Compare with previous version

    By Antoine Fontaine on 2020-12-23T21:19:41

  • Author Owner

    I've rebased on master and moved what could be to modules for @edp17. I've tested that it builds, but I have not tested it works fine. Hopefully nothing should break when moved to modules.

    By Antoine Fontaine on 2020-12-23T22:31:14

  • Administrator resolved all threads · Imported

    resolved all threads

    By Antoine Fontaine on 2020-12-23T22:31:42

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading