Skip to content
Snippets Groups Projects

main/waydroid-image: remove

Merged Imported Administrator requested to merge rm-waydroid-image into master

This has been out-of-date for almost a year with seemingly stalled progress on the existing upgrade MR (!3091 (closed)) for months now; it really seems like no one wants to maintain this which currently leaves this "force-installed-by-default" packaged image broken on all wlroots-based Wayland compositors for example as it stands which users have also started to report (#1653 (closed)).

I previously added the echo !waydroid-image >> /etc/apk/world tip on https://wiki.postmarketos.org/wiki/Waydroid#Installation but if everyone needs to do that to use Waydroid why should this package even exist?

Another solution could be to simply remove the install_if="waydroid" which currently makes this image "forced" on users that install waydroid without messing with /etc/apk/world as mentioned above. Without the install_if the docs could be updated to simply say the following instead and imho it wouldn't be a problem:

$ sudo apk add waydroid waydroid-image

Cc. @Newbyte (who I already talked with about this previously and the response to should the package be removed was I don't think so. The default image should be good enough for most people, and I think it is more intuitive if the default image gets installed automatically)

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator changed the description · Imported

    changed the description

    By Jami Kettunen on 2022-10-08T19:06:21

  • Administrator assigned to @PureTryOut · Imported

    assigned to @PureTryOut

    By Alexey Min on 2022-10-08T19:38:58

  • Administrator changed the description · Imported

    changed the description

    By Jami Kettunen on 2022-10-08T19:45:51

  • Administrator added discussion label · Imported

    added discussion label

  • Author Owner

    Perhaps an alternative could be to remove install_if="waydroid" until someone wants to maintain this. I don't have any strong opinion though, I don't use Waydroid at the moment. Maybe I will once I have a daily-drivable pmOS phone again.

    By Newbyte on 2022-10-08T20:04:03

  • Author Owner

    I'm not sure. Originally I really thought pre-shipping an image would be the better way to make sure we control the image and can be sure things work and work like we want them too. However updating it can be a bit of a pain, and it's a deviation of how every other distribution does it. Besides, I kinda don't want to have to maintain an Android image, seeing we're trying to get rid of Android here :sweat_smile:

    In general I find Waydroid a bit of an issue, I find it more like a hack than a proper solution. I wish Jolla's AlienDalvik (or whatever it's called now) was open-source as I really felt that was a better solution.

    So I suppose we could just remove our image and prefer upstream's way of retrieving it instead; it's less maintenance for us and it would bring us in line with other distributions. Also if somebody wants to take over maintenance of Waydroid in Alpine that would be lovely :sweat_smile:

    By Bart Ribbers on 2022-10-14T07:17:05

    Edited by Administrator
  • Author Owner

    Just my two cents, I wanted to test Waydroid maybe a month ago and I couldn't get it to work. I should probably try again without this image then.. :thinking:

    By Luca Weiss on 2022-10-10T20:20:59

  • Author Owner

    +1 for dropping this, if someone has the time + energy to maintain it and we can properly benefit from pmOS specific fixes that way then that makes some sense. But it seems to cause more problems than it solves as is.

    By Caleb Connolly on 2022-10-11T07:49:26

  • Administrator approved this merge request · Imported

    approved this merge request

    By Caleb Connolly on 2022-10-11T07:49:36

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2022-10-12T06:56:23

  • Author Owner

    Makes sense to me to remove it with the reasoning given. Thanks @deathmist!

    By Oliver Smith on 2022-10-12T06:56:45

  • Administrator added 40 commits · Imported

    added 40 commits

    Compare with previous version

    By Oliver Smith on 2022-10-12T06:57:31

  • Administrator enabled an automatic merge when the pipeline for 1d88d8bc succeeds · Imported

    enabled an automatic merge when the pipeline for 1d88d8bc succeeds

    By Oliver Smith on 2022-10-12T06:57:53

  • Administrator merged · Imported

    merged

  • Author Owner

    We should probably do this for v22.06 as well. I've added it to #1683 (closed), so we can inform users about it in the service pack blog post. Also added upgrading waydroid to latest in the service pack.

    By Oliver Smith on 2022-10-12T07:01:30

  • Administrator mentioned in issue #1653 (closed) · Imported

    mentioned in issue #1653 (closed)

    By Oliver Smith on 2022-10-12T18:41:30

  • Administrator mentioned in issue #1683 (closed) · Imported

    mentioned in issue #1683 (closed)

    By Oliver Smith on 2022-10-16T11:07:25

  • Administrator mentioned in issue #1849 (closed) · Imported

    mentioned in issue #1849 (closed)

    By Oliver Smith on 2023-02-23T22:21:36

Please register or sign in to reply
Loading