Skip to content
Snippets Groups Projects

Draft: linux-postmarketos-exynos5: fix panel timings for samsung-manta

Closed Imported Administrator requested to merge device/community/linux-postmarketos-exynos5/manta-display into master
2 unresolved threads

This fixes the panel timing parameters for the samsung-manta by backporting the fixes from 1.

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator changed the description · Imported

    changed the description

    By Marian Buschsieweke on 2024-07-09T12:59:07

  • Administrator mentioned in issue #2615 · Imported

    mentioned in issue #2615

    By Marian Buschsieweke on 2024-07-09T13:00:26

  • Administrator mentioned in issue #3000 · Imported

    mentioned in issue #3000

    By Marian Buschsieweke on 2024-07-10T08:12:30

    • Author Owner

      I'm not sure we should backport it to edge. It will come to edge eventually with linux-postmarketos-exynos5 upgrade, although it probably makes sense to backport it to v24.06

      By jenneron on 2024-07-12T09:03:06

      Edited by Ghost User
    • Author Owner

      I would disagree, as if this MR would actually solves the issue, it would allow users to just flash their devices and it would work out of the box.

      I could add a note to the patches and not just to the commit message to make it more obvious that the patches should be dropped after an upgrade. (But given that they will conflict anyway, there is no chance that this is missed.)

      However, my tablet doesn't boot reliably with any variant of linux-ppostmarketos-exynos5 (I tested with this MR, the variant in edge, and the HEAD of master in https://gitlab.com/exynos5-mainline/linux).

      By Marian Buschsieweke on 2024-07-12T09:03:06

    • Author Owner

      I'm not against fixing this, I'm just saying that we should upgrade linux-postmarketos-exynos5 with fixes included instead

      If these fixes are not present in exynos5-mainline/linux we should merge it there

      By jenneron on 2024-07-13T15:37:46

    • Author Owner

      The fixes have been merged already, but the most recent tag is from before those where merged. So once a tag is created, this MR would be obsolete.

      By Marian Buschsieweke on 2024-07-13T17:45:19

    • Author Owner

      I'll look at creating a new tag this weekend, based on 6.10

      By Henrik Grimler on 2024-07-17T16:31:57

      Edited by Ghost User
    • Author Owner

      Thx!

      By Marian Buschsieweke on 2024-07-17T16:32:24

    • Author Owner

      @grimler: A friendly reminder :)

      By Marian Buschsieweke on 2024-07-22T09:08:01

    • Author Owner

      Yeah, ran into some other issues that had to be fixed first (!5365 (merged)). Have forced pushed to the lts-6.6.x branch, but not finished testing all the devices yet, plan is to finish it today!

      By Henrik Grimler on 2024-07-22T10:46:41

    • Author Owner

      (And yeah, new tag will be based on 6.6.41 and not 6.10 as I said earlier, as we have decided to use LTS versions for exynos5)

      By Henrik Grimler on 2024-07-22T10:50:06

    • Please register or sign in to reply
  • Administrator closed · Imported

    closed

  • Author Owner

    (This MR is not needed anymore, given that the tag is about to be created anyway.)

    By Marian Buschsieweke on 2024-07-17T16:33:25

Please register or sign in to reply
Loading