Skip to content
Snippets Groups Projects

WIP: semc-anzu: patch kernel to add/fix additional framebuffer modes, use fbset to set them for graphics environments

Closed Imported Administrator requested to merge asiekierka:anzu-fix-pixman-type into master

Apologies for the omission.

If #1088 (closed) requires any additional changes in device-semc-anzu, it's probably a good idea to delay this pull request until said changes are done.

Also, is there any official route for hooking physical buttons on a device yet? On this device, event0 handles the power button and event1 handles Volume/Back/Home/Menu keys. Plasma Mobile seems to detect both as keyboards.

Edited by Administrator

Merge request reports

Approval is optional

Closed by AdministratorAdministrator 6 years ago (Jul 9, 2018 7:02pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    Checksum updated.

    By Adrian Siekierka on 2018-01-06T22:41:12

  • Author Owner

    I am still looking for a better solution, as Xorg also seems to have issues (xfce4 segfault).

    By Adrian Siekierka on 2018-01-06T23:02:37

  • Author Owner

    Created by: ollieparanoid

    There's also a kernel patch you could try out. But that might cause the wrong colors to appear in kwin. You might also need a X11 config file.

    So I'm merging this not yet if you still want to experiment with it - just let me know when you think it is ready :wink:

    By * postmarketOS Bot on 2018-01-06T23:11:57

    Edited by Ghost User
  • Author Owner

    Yes, I think I can come up with something better. Managed to add a new display mode to the framebuffer in an experiment and this will hopefully let me support everything more properly.

    By Adrian Siekierka on 2018-01-07T01:14:11

  • Author Owner

    Initial progress - I have managed to patch the Qualcomm framebuffer driver to add multiple missing framebuffer modes (BGR_888 and ABGR_8888, as well as many modes which weren't fully implemented in the code), however autodetection seems to be broken in both Weston and Xorg. As such, for the time being, I have to call both fbset (different modes for Weston and Xorg!) and pass a pixman_type to Weston.

    TODO:

    • Consult documentation and check if endianness differences aren't the issue for Weston's detection problems
    • Test plasma-mobile

    By Adrian Siekierka on 2018-01-07T12:43:08

  • Author Owner

    Okay, this works with Weston, Xorg-based environments and KWin (plasma-mobile). All that needs to be tested now is osk-sdl, but I won't be able to do so for the next week or so.

    There's another issue preventing Xorg and KWin from working out of the box, though: msm-fb-refresher doesn't seem to launch automatically on those!

    EDIT: There's a couple of devices which share the same framebuffer logic (MDP40) and might benefit from this patch: sony-yuga, samsung-i9505, samsung-i747m, lg-mako, htc-ace - assuming they also suffer from xfce4/kwin issues.

    By Adrian Siekierka on 2018-01-07T16:22:57

    Edited by Ghost User
  • Author Owner

    Please do not merge this PR until I verify that the patch in https://github.com/postmarketOS/pmbootstrap/pull/1005 isn't an infinitely simpler way to accomplish the same thing.

    By Adrian Siekierka on 2018-01-07T19:50:37

  • Author Owner

    Created by: PureTryOut

    So, @asiekierka, did you manage to verify that patch yet?

    By * postmarketOS Bot on 2018-03-31T21:46:35

  • Administrator marked as a Work In Progress · Imported

    marked as a Work In Progress

    By Martijn Braam on 2018-06-30T13:14:38

  • Author Owner

    This merge request has been stalled for half a year now, closing.

    @asiekierka or anyone else: if you have updated the code for another review, please open up a new merge request.

    By Oliver Smith on 2018-07-09T19:02:35

  • Administrator closed · Imported

    closed

    By Oliver Smith on 2018-07-09T19:02:37

Please register or sign in to reply
Loading