Skip to content
Snippets Groups Projects

WIP: Add support for a separate aports directory & repository.

Merged Imported Administrator requested to merge marmistrz:aportssep into master

Created by: marmistrz

Closes #383 (closed). Contains changes from #1454 (to avoid later rebasing)

NB, If Python 3.6 were supported, a much cleaner PEP-498 could be used:

        logging.fatal(f"    git clone {APORTS_GIT} {args.aports}")

[x] Merge on GitHub (see https://postmarketos.org/merge)

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    Created by: marmistrz

    I'm wondering why the tests on 0a1f92cc fail in the place they do. pmbootstrap should actually fail at the very beginning, not able to find the aports.

    By * postmarketOS Bot on 2018-04-30T17:56:36

  • Administrator marked as a Work In Progress · Imported

    marked as a Work In Progress

    By Martijn Braam on 2018-06-30T13:12:04

  • Administrator changed the description · Imported

    changed the description

    By Martijn Braam on 2018-06-30T13:12:04

  • Author Owner

    NB, If Python 3.6 were supported, a much cleaner PEP-498 could be used:

    @marmistrz: That looks clean indeed! Right now we're supporting Python 3.4+, so we can't use it yet.

    For the record, this message I wrote was not imported correctly:

    I think there's more that needs to be done beforehand, see #383 (comment 85245691)


    Unfortunately, this merge request was not imported correctly from GitHub:

    source branch does not exist. Please restore it or use a different source branch

    @marmistrz or anyone else: if you have updated the code for another review, please open up a new merge request. Sorry for the trouble.

    By Oliver Smith on 2018-07-09T19:44:52

    Edited by Administrator
  • Administrator closed · Imported

    closed

    By Oliver Smith on 2018-07-09T19:44:56

Please register or sign in to reply
Loading