Skip to content
Snippets Groups Projects

pmb/config: add required option for Waydroid support

Merged Imported Administrator requested to merge waydroid into master
1 unresolved thread

CONFIG_PSI is required for Waydroid Android containers, it's used by a userspace OOM killer within Android. See https://gitlab.com/postmarketOS/pmaports/-/merge_requests/2497 for more details.

Marking this draft for now as it might have a performance impact we don't want and thus needs testing before we decide on this permanently.

Edited by Administrator

Merge request reports

Checking pipeline status.

Approved by

Merged by AdministratorAdministrator 3 years ago (Sep 13, 2021 6:21pm UTC)

Merge details

  • Changes merged into master with 4675def8.
  • Deleted the source branch.

Pipeline #187895 passed

Pipeline passed for 4675def8 on master

Deployed to dep‎loy‎ 5 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Author Owner

    Thanks for the patch! Besides mentioned nitpicks, this looks good. Makes sense to add it to pmbootstrap kconfig check --anbox.

    By Oliver Smith on 2021-09-09T23:04:45

  • Author Owner

    Also dumping this here for reference: https://source.android.com/devices/tech/perf/lmkd

    By Luca Weiss on 2021-09-11T21:16:23

  • Administrator added 4 commits · Imported

    added 4 commits

    Compare with previous version

    By Oliver Smith on 2021-09-12T21:05:04

    • Author Owner

      @z3ntu: thanks! looks like we can drop it at some point again, when the image doesn't use the kernel-side PSI anymore.

      Resolved my own comments and added PSI_DEFAULT_DISABLED too, so it's consistently enabled by default.

      Anybody wants to do a second review & merge?

      By Oliver Smith on 2021-09-16T12:57:10

      Edited by Ghost User
    • Author Owner

      looks like we can drop it at some point again, when the image doesn't use the kernel-side PSI anymore.

      Android doesn't use the kernel thing anymore, that's the whole reason why this PSI thing is required :thinking: I don't think I understand this comment?

      By Bart Ribbers on 2021-09-16T12:57:10

    • Please register or sign in to reply
  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2021-09-12T21:06:54

  • Administrator marked this merge request as ready · Imported

    marked this merge request as ready

    By Oliver Smith on 2021-09-12T21:07:18

  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2021-09-12T21:07:57

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2021-09-13T18:09:06

  • Administrator added 6 commits · Imported

    added 6 commits

    Compare with previous version

    By Alexey Min on 2021-09-13T18:10:21

  • Administrator enabled an automatic merge when the pipeline for 4675def8 succeeds · Imported

    enabled an automatic merge when the pipeline for 4675def8 succeeds

    By Alexey Min on 2021-09-13T18:10:38

  • Administrator merged · Imported

    merged

  • Please register or sign in to reply
    Loading