Skip to content
Snippets Groups Projects

pmbootstrap status: rework

Merged Imported Administrator requested to merge rework-pmbootstrap-status-2 into master
All threads resolved!

Reimplement "pmbootstrap status" to be just a simple and useful status overview. The previous version ran a bunch of checks every time, and would fail on these even if pmaports was used for normal development:

  • "non-official" branch checked out in pmaports
  • pmaports.git is not clean

The information about aports.git was also considered not so useful upon revisiting this command, since it is only used for "pmbootstrap aportgen". Most users don't need this, and if the user runs this command, it will tell if aports.git is outdated.

All of the above made the previous version unpleasant to use and I suspect most people stopped using the command after trying it out a few times and seeing the irrelevant but loud NOK complaints.

New version:

  $ pmbootstrap status
  Channel: edge (pmaports: master_staging_systemd)
  Device:  qemu-amd64 (x86_64, kernel: virt)
  UI:      console
  systemd: no (default for selected UI)

Old version (without --details it only shows NOK checks):

  $ pmbootstrap status --details
  [00:55:20] *** CONFIG ***
  [00:55:20] Device: qemu-amd64 (x86_64, "QEMU amd64")
  [00:55:20] Kernel: virt
  [00:55:20] User Interface: console
  [00:55:20]
  [00:55:20] *** GIT REPOS ***
  [00:55:20] Path: /home/user/.local/var/pmbootstrap/cache_git
  [00:55:20] - aports_upstream (master)
  [00:55:20] - pmaports (master)
  [00:55:20]
  [00:55:20] *** CHECKS ***
  [00:55:20] [OK ] Chroots zapped recently (or non-existing)
  [00:55:20] [OK ] aports_upstream: on official channel branch
  [00:55:20] [OK ] aports_upstream: workdir is clean
  [00:55:20] [OK ] aports_upstream: tracking proper remote branch 'origin/master'
  [00:55:20] [OK ] aports_upstream: up to date with remote branch
  [00:55:20] [OK ] aports_upstream: remote information updated recently (via git fetch/pull)
  [00:55:20] [OK ] pmaports: on official channel branch
  [00:55:20] [OK ] pmaports: workdir is clean
  [00:55:20] [OK ] pmaports: tracking proper remote branch 'origin/master'
  [00:55:20] [OK ] pmaports: up to date with remote branch
  [00:55:20] [OK ] pmaports: remote information updated recently (via git fetch/pull)
  [00:55:20]
  [00:55:20] NOTE: chroot is still active (use 'pmbootstrap shutdown' as necessary)
  [00:55:20] DONE!

Fix #1903 (closed)

Merge request reports

Checking pipeline status.

Approved by

Merged by AdministratorAdministrator 11 months ago (Apr 16, 2024 7:03pm UTC)

Merge details

Pipeline #190619 passed

Pipeline passed for 0d320d06 on master

Deployed to dep‎loy‎ 6 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator resolved all threads · Imported

    resolved all threads

    By Oliver Smith on 2024-04-11T23:20:16

  • Administrator added 3 commits · Imported

    added 3 commits

    Compare with previous version

    By Oliver Smith on 2024-04-11T23:33:21

  • Administrator added 1 commit · Imported

    added 1 commit

    • 09ce9c67 - pmbootstrap status: rework (MR 2294)

    Compare with previous version

    By Oliver Smith on 2024-04-11T23:54:29

  • Author Owner

    The old "pmbootstrap status" code used to tell the user that they should run "pmbootstrap pull" if the last fetch was more than 2 days ago. I think it's much better to recommend "pmbootstrap pull" in the warning shown when packages are newer in binary repos compared to pmaports, so I've put it there: !2295 (merged)

    By Oliver Smith on 2024-04-12T00:06:57

  • Administrator added 1 commit · Imported

    added 1 commit

    • 428934ae - pmbootstrap status: rework (MR 2294)

    Compare with previous version

    By Oliver Smith on 2024-04-12T00:11:24

  • Administrator approved this merge request · Imported

    approved this merge request

    By Caleb Connolly on 2024-04-14T15:24:02

  • Administrator added 2 commits · Imported

    added 2 commits

    • 8b0dfe48 - 1 commit from branch postmarketOS:master
    • 905a9d24 - pmbootstrap status: rework (MR 2294)

    Compare with previous version

    By Oliver Smith on 2024-04-14T15:34:11

  • Author Owner

    (unrelated CI failures, because of https://postmarketos.org/edge/2024/03/12/python-3.12/ - let's wait a bit with merging then)

    By Oliver Smith on 2024-04-14T15:35:42

  • Administrator added 5 commits · Imported

    added 5 commits

    Compare with previous version

    By Oliver Smith on 2024-04-16T18:55:10

  • Administrator enabled an automatic merge when the pipeline for 0d320d06 succeeds · Imported

    enabled an automatic merge when the pipeline for 0d320d06 succeeds

    By Oliver Smith on 2024-04-16T18:55:52

  • Administrator changed milestone to %initial systemd support · Imported

    changed milestone to %initial systemd support

  • Administrator merged · Imported

    merged

  • Administrator mentioned in merge request !2295 (merged) · Imported

    mentioned in merge request !2295 (merged)

    By Oliver Smith on 2024-04-16T19:03:19

  • Please register or sign in to reply
    Loading