makefile: install scripts to bin instead of sbin, use PREFIX for systemd unit install location

added 1 commit

• 65187ee0 - makefile: change install to install everything

Compare with previous version

By clayton craft on 2024-09-29T19:03:12

LGTM

By Luca Weiss on 2024-09-29T21:22:05

Thank you very much!

The remaining issue #2 (closed) is that the paths of the shell scripts are not only in the Makefile but also in the service scripts. The following link shows one example (it affects 2x openrc and 2x systemd). To my understanding that means that the content of the service scripts would need to be "dynamically" changed upon build. I don't know how to do this.

• https://gitlab.postmarketos.org/postmarketos/swclock-offset/-/blob/master/openrc/swclock-offset-boot.initd#L16

On the commit installing everything by "install": The files were moved from pmaports/main to a separate repository to make it available to other distributions for building. Specifically it was about AsteroidOS at that time. They use systemd. It doesn't make much sense for them to install the openrc scripts as well. Is it really common to remove stuff after make install? I'm no so much familiar with building. The idea of the dedicated install commands was to have the ability to choose what to install.

By Jakko on 2024-10-04T20:08:50

TODO: update readme to reflect changes

By clayton craft on 2024-10-03T19:09:20

changed milestone to %initial systemd support

added 3 commits

• 7df36dee - makefile: drop PREFIX, comply with /usr merge
• 2df01ded - makefile: simplify install
• 61663762 - readme: build: update to reflect recent 'make' PREFIX and install changes

Compare with previous version

By clayton craft on 2024-10-03T19:08:13

approved this merge request

By Jakko on 2024-10-04T20:03:32

Feel free to merge.

By Jakko on 2024-10-04T20:10:39

thanks! would you like to tag a new release or shall I? (or do you want to wait for something else?)

By clayton craft on 2024-10-04T20:10:39

Feel free to merge.

Well, I just did myself. And created tag 0.2.3.

By Jakko on 2024-10-04T20:15:42

great, thanks a lot for the help

By clayton craft on 2024-10-04T20:17:32

enabled an automatic merge when all merge checks for 61663762 pass

By Jakko on 2024-10-04T20:08:34

resolved all threads

By Jakko on 2024-10-04T20:08:50

merged

mentioned in issue #2 (closed)

By Jakko on 2024-10-04T20:18:29

mentioned in merge request !5 (merged)

By Jakko on 2024-10-05T07:44:18