test: conftest: adjust pmaports fixture (MR 2477)

make sure that calls to get_upstream_remote() will succeed by setting
pmb.config.git_repos() for the entire run. This might pollute some other
tests...

TODO: make less things depend on pmaports being cloned...

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

pmb/conftest.py

@@ -161,14 +161,14 @@ def pmaports(pmb_args, monkeypatch):
 
     config = get_context().config
 
-    with monkeypatch.context() as m:
-        # Speed things up by cloning from the local checkout if it exists.
-        if Config.aports[0].exists():
-            m.setitem(pmb.config.git_repos, "pmaports", Config.aports)
+    if Config.aports[-1].exists():
+        pmb.config.git_repos["pmaports"] = [str(Config.aports[-1])]
 
+    if not config.aports[-1].exists():
         pmb.helpers.git.clone("pmaports")
-
-    assert pmb.helpers.run.user(["git", "checkout", "master"], working_dir=config.aports[0]) == 0
+        assert (
+            pmb.helpers.run.user(["git", "checkout", "master"], working_dir=config.aports[0]) == 0
+        )
 
 
 @pytest.fixture