- Feb 02, 2025
-
-
-
-
-
-
-
-
This is equivalent and simpler. See https://docs.astral.sh/ruff/rules/multiple-starts-ends-with
-
- Feb 01, 2025
-
-
knuxify authored
Commit 37ec73c0 dropped the use of args to access command line arguments, but did not add another way to pass command line arguments; thus, optional flags to flash_kernel, flash_rootfs, flash_lk2nd, sideload and list_devices were ignored. Fix this by making sure the relevant arguments are passed for all frontend methods. Fixes #2522.
-
- Jan 28, 2025
-
-
- Jan 19, 2025
-
-
Oliver Smith authored -
-
-
- Jan 16, 2025
-
-
Newbyte authored
Without this, `$ pmbootstrap init` crashes if a nonexistent UI package is selected. This can happen if one previously selected a UI package in a former checkout of pmaports, but then switched away to a different one that doesn't have the UI package. For example, if someone is working on a new UI in a feature branch and then switches away from it, or if a UI is removed from the canonical pmaports repository altogether.
-
Newbyte authored
Will be used in the next commit.
-
- Jan 15, 2025
-
-
And remove hack needed to accomodate this wrong type.
-
This has been done now.
-
This was probably fixed by 225d8b30 as it added an Env type hint to the env variable. Either way, the mypy check passes evenn with this removed now.
-
pmbootstrap install --android-recovery-zip always failed with: ERROR: The recovery zip has not been generated yet, please run 'pmbootstrap install' with the '--android-recovery-zip' parameter first! I debugged it with a simple print statement of the full path and saw a repetition of the first part of the path. I discovered that the mountpoint is "/mnt/" + chroot, so adding chroot again leads to a repetition of the first part of the path and to a non-existent location. Closes: issue 2441
-
Oliver Smith authored
Looks like there was a missing comma when this was added initially. Caught this while reviewing the formatting patch.
-
The Alpine version is too outdated.
-
-
These values are already integers, so calling round() on them is effectively a no-op.
-
-
-
-
The unpacking operator can unpack any iterable of any type, unlike the + operator which only works on some sequences and requires them to be of the same type usually. Using it allows us to get rid of the line that disables the "operator" error code for this function.
-
These seem pretty useful to me. I ignored RUF021 since it seems a bit silly to me and I didn't see the point in fixing the one violation of it that we have in the code, but if you're reading this in the future and want to do so be my guest, I don't really care either way.
-
See https://docs.astral.sh/ruff/rules/collection-literal-concatenation This is also slightly faster according to a microbenchmark that shows it taking around 19% less time to run: https://github.com/astral-sh/ruff/pull/1957#issue-1538092351
-
-
While it probably wasn't the intent, this is what they are in practice. Mark them as such to help mypy. See https://docs.astral.sh/ruff/rules/mutable-class-default
-
This shouldn't change at runtime, so avoid any potential issues with it being a mutable class variable by making it immutable.
-
-
Not sure why this was added, but Ruff doesn't complain if I remove it.
-
Integers automatically get converted to strings when used in f-strings like this, so just get rid of this explicit conversion.
-
-
I'm guessing this was meant to be an f-string given that it uses the formatting syntax for those.
-
- Jan 12, 2025
-
-
Oliver Smith authored
Write a preset file and run "systemctl preset" afterwards: % sh -c echo 'disable sshd.service' > /usr/lib/systemd/system-preset/80-pmbootstrap-install-disable-sshd.preset % systemctl preset sshd.service % systemctl is-enabled sshd.service disabled -
Oliver Smith authored
These functions are identical, except for the service name. Merge them in preparation to add systemd support.
-
Merge strings that have a break in the same line. These were generated when running "ruff format" initially. Old: logging.info("Firewall is not supported in checked out pmaports" " branch.") New: logging.info("Firewall is not supported in checked out pmaports branch.") Signed-off-by:Robert Eckelmann <longnoserob@postmarketos.org> Tweaked-by:
Oliver Smith <ollieparanoid@postmarketos.org>
-
- Jan 10, 2025
-
-
Oliver Smith authored
Now that systemd was merged into master, it is extra-repos/systemd instead of staging/systemd. As of writing, the repository is not published yet but this will happen soon. Related: https://postmarketos.org/edge/2025/01/09/systemd-soon/
-
