Draft: add config option for setting display rotation

This will allow distros and/or users to force a certain display rotation on devices where it's not correctly detected/used by buffyboard directly.

The idea is that pmOS (or other distros) can install (from a device package) a .conf file to force rotation to be a certain way when we are confident that it'll only really ever be in one direction for that device.

This is basically a janky workaround for #14. It needs a bit more work to make it functional, so maybe it's just easier to fix the original problem @ #14?

mentioned in issue #14

By clayton craft on 2024-07-01T21:52:15

Thanks for submitting this and sorry it has taken me so embarrassingly long to respond. I think adding a config option to control rotation is a good feature. Doing auto-detection would be nicer but this helps people help themselves and would still be useful as a fallback if we ever get auto-detection.

It needs a bit more work to make it functional [...]

Are the only things missing mirroring the config option to unl0kr and finding a way to let the CLI option overwrite the config option?

For the latter, maybe a fix could be to have a single shared options structure that gets passed through the config parsing first and the CLI parsing second.

Since, I think, this is the first option that requires overriding logic, a poor-man's additional boolean flag in the CLI options struct would probably also be acceptable.

By Johannes Marbach on 2024-07-16T18:55:54

Are the only things missing mirroring the config option to unl0kr and finding a way to let the CLI option overwrite the config option?

For the latter, maybe a fix could be to have a single shared options structure that gets passed through the config parsing first and the CLI parsing second.

@cherrypicker do you still feel like this might be a good way to implement this or do you have some other ideas?

I feel like it might be the cleanest way, yeah. It'll mean merging the options structs, applying one set of defaults, then overriding options with the config first and CLI second.

That being said, I'm totally open for other ideas.

added status::mr-stale label

Sorry to bother you @craftyguy,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC. If no further activity occurs in this MR, postmarketOS developers may close it in the future.

Thanks for your contribution.

By * postmarketOS Bot on 2024-09-27T19:10:22

closed

reopened

mentioned in merge request !32 (merged)