unl0kr: add a CLI option to show a custom message

Fixes: #33 (closed)

mentioned in issue pmaports#3535

This looks great, thank you. The CLI options are, somewhat confusingly, also mentioned in the man page and the README. Could you also add the -m switch there?

Unl0kr used to have a similar message a long time ago until I removed it because I couldn't figure out the proper alignment in different resolutions. Have you tried this in different resolutions and message lengths? If you're able to run this on a large monitor, you could also try using the adapting the regenerate-screenshots.sh script to get an overview of how the message looks like in different scenarios.

Oh, and could you add a changelog entry, too?

added 7 commits

• 45dda59a...56a9867e - 6 commits from branch postmarketOS:master
• e292274b - unl0kr: add a CLI option to show a custom message

Compare with previous version

added 18 commits

• e292274b...18b576f2 - 16 commits from branch postmarketOS:master
• b44d6464 - unl0kr: add a CLI option to show a custom message
• 803adaac - unl0kr: update screenshots

Compare with previous version

marked this merge request as ready

Ready for testing. I made a container for the message and the textarea scrollable, so should work for long messages also.

A side question: what was a reason to introduce bbx_theme instead of using lv_theme_t and lv_style_t directly? Styles also support compile-time definitions:

const lv_style_const_prop_t style1_props[] = {
   LV_STYLE_CONST_WIDTH(50),
   LV_STYLE_CONST_HEIGHT(50),
   LV_STYLE_CONST_PROPS_END
};

LV_STYLE_CONST_INIT(style1, style1_props);

added 2 commits

• 128ed3b3 - unl0kr: add a CLI option to show a custom message
• 1fa86df5 - unl0kr: update screenshots

Compare with previous version

We should fix nord-dark theme somehow. The text is almost invisible here.

I agree. Starting thread.

I have not read the specification. Just a quick fix.

added 2 commits

• 90a8355e - unl0kr: add a CLI option to show a custom message
• 27230da7 - unl0kr: update screenshots

Compare with previous version

added 2 commits

• 54a05226 - unl0kr: add a CLI option to show a custom message
• 213f6baa - unl0kr: update screenshots

Compare with previous version

Oh, this looks nice! Thanks also for fixing the nord colour bug.

Is there an easy way to keep the text input closer to the keyboard instead of centering message and text? I think that could be preferable for typing but don't have a strong opinion.

A side question: what was a reason to introduce bbx_theme instead of using lv_theme_t and lv_style_t directly?

If we can express everything in bbx_theme via style props, I wouldn't be opposed to switching at all. I think my main reasoning at the time was that I wanted to keep the themes easy enough to edit by non-technical people. However, that might be catered to better by proper user theming (#19) anyway.

For some reason lv_obj_set_align(message_label, LV_ALIGN_BOTTOM_LEFT); disables scrolling, so I introduced a spacer instead.

Amazing! Thanks for making this work in all the various resolutions and themes.

added 2 commits

• 84d47d28 - unl0kr: add a CLI option to show a custom message
• cf20c4a2 - unl0kr: update screenshots

Compare with previous version

approved this merge request

mentioned in commit 169a1ac5

merged