CI: add shellcheck

.ci/flake8.sh

@@ -2,6 +2,7 @@
 topdir="$(realpath "$(dirname "$0")/..")"
 cd "$topdir"
 
-flake8 $(find -name '*.py')
+# shellcheck disable=SC2046
+flake8 $(find . -name '*.py')
 
 echo "flake8 check passed"

.ci/shellcheck.sh

+#!/bin/sh -e
+topdir="$(realpath "$(dirname "$0")/..")"
+cd "$topdir"
+
+# shellcheck disable=SC2046
+shellcheck $(find . -name '*.sh')
+
+echo "shellcheck passed"

.gitlab-ci.yml

@@ -6,3 +6,10 @@ flake8:
   - "pip3 -q --disable-pip-version-check install flake8"
   script:
   - ".ci/flake8.sh"
+
+shellcheck:
+  image: "alpine:latest"
+  before_script:
+  - "apk -q add shellcheck"
+  script:
+  - ".ci/shellcheck.sh"

install_pmbootstrap.sh

@@ -8,7 +8,7 @@ tag="master"
 url="https://gitlab.com/postmarketOS/pmbootstrap.git"
 
 # pmaports: either checked out in current dir, or let pmbootstrap download it
-pmaports="$(cd $(dirname $0)/..; pwd -P)"
+pmaports="$(cd "$(dirname "$0")"/..; pwd -P)"
 pmaports_arg=""
 if [ -e "$pmaports/pmaports.cfg" ]; then
 	echo "Found pmaports.cfg in current dir"
@@ -16,8 +16,9 @@ if [ -e "$pmaports/pmaports.cfg" ]; then
 fi
 
 # Set up depends and binfmt_misc
-depends="coreutils openssl python3 sudo git $@"
+depends="coreutils openssl python3 sudo git $*"
 echo "Installing dependencies: $depends"
+# shellcheck disable=SC2086
 apk -q add $depends
 mount -t binfmt_misc none /proc/sys/fs/binfmt_misc