Skip to content
Snippets Groups Projects

Add modemmanager driver

Merged Imported Administrator requested to merge mm into master

Uses the dbus go module to talk to ModemManager. Gets locations by polling the GetLocation MM method and supports loading A-GPS / XTRA data from a file (/var/cache/gnss-share/xtra.bin) with the MM API.

Tested on the Pinephone and Oneplus 6. Everything works fine on short tests, but disappearing and appearing modems are not supported yet and this probably causes things to break eventually, at least on the Pinephone.

Does not enable A-GPS MSA or MSB, as this does not seem to improve performance on the Pinephone, and is not supported on Oneplus 6.

This is progress towards solving #10.

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Administrator
  • Administrator
  • Administrator
  • Administrator
  • Administrator
  • Administrator
  • Administrator
    • Author Owner
      Resolved by Administrator

      @tpikonen I'm very sorry it has taken me so long to review this... I'll try to do better in the future about responding to your patches here.

      Overall this looks really good! It was also a good test of how well I'd be able to come back to this project and review big changes for it... so most of my initial feedback is for adding comments to hopefully make it easier to review/maintain your additions in the future. I'm really excited to see this being added, well done!

      I haven't actually tried to run any of it, but I would like to before merging just so I can "see" how it works :)

      By clayton craft on 2023-10-28T17:49:55

      Edited by Ghost User
  • Administrator mentioned in merge request !11 (closed) · Imported

    mentioned in merge request !11 (closed)

    By Teemu Ikonen on 2023-10-19T08:33:23

  • Administrator added 1 commit · Imported

    added 1 commit

    Compare with previous version

    By Teemu Ikonen on 2023-10-20T11:16:02

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading