Add modemmanager driver
Uses the dbus go module to talk to ModemManager. Gets locations by polling the GetLocation
MM method and supports loading A-GPS / XTRA data from a file (/var/cache/gnss-share/xtra.bin
) with the MM API.
Tested on the Pinephone and Oneplus 6. Everything works fine on short tests, but disappearing and appearing modems are not supported yet and this probably causes things to break eventually, at least on the Pinephone.
Does not enable A-GPS MSA or MSB, as this does not seem to improve performance on the Pinephone, and is not supported on Oneplus 6.
This is progress towards solving #10.
Merge request reports
Activity
mentioned in issue #10
By Teemu Ikonen on 2023-09-04T18:20:55
- Resolved by Administrator
Thank you very much!
@craftyguy: you seem to be most active in the repository, can you take a look at this when you have time?
By Oliver Smith on 2023-10-12T22:10:46
Edited by Ghost User
The latest version now survives modem disappearing and appearing.
By Teemu Ikonen on 2023-10-20T11:33:03
Edited by Ghost User- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
- Resolved by Administrator
@tpikonen I'm very sorry it has taken me so long to review this... I'll try to do better in the future about responding to your patches here.
Overall this looks really good! It was also a good test of how well I'd be able to come back to this project and review big changes for it... so most of my initial feedback is for adding comments to hopefully make it easier to review/maintain your additions in the future. I'm really excited to see this being added, well done!
I haven't actually tried to run any of it, but I would like to before merging just so I can "see" how it works :)
By clayton craft on 2023-10-28T17:49:55
Edited by Ghost User
mentioned in merge request !11 (closed)
By Teemu Ikonen on 2023-10-19T08:33:23