Peter Mack authored 1 year ago and Oliver Smith committed 1 year ago

popups.css: Fix various popup menus and installing extensions, including a fix for the overflow menu (MR 47)

Peter Mack authored 1 year ago and Newbyte committed 1 year ago

Closes https://gitlab.com/postmarketOS/mobile-config-firefox/-/issues/63

Peter Mack authored 1 year ago and Oliver Smith committed 1 year ago

Based on user0's work, I've implemented a slightly different fix for
this menu:

* max-width only, because that's enough to fix the menu
* 100% instead of 100vw, as that's less in most cases, but enough.

Related: https://codeberg.org/user0/mobile-config-firefox/src/commit/f2381fd45eeef10ffb173a56f8106e6d68b981be/src/userChrome/06_popups.css#L85-L89
Fixes: #65

Prevent the user from installing to the wrong firefox dir, and give a
userfriendly message if install needs root rights.

Make it easy for users to test versions from a git repository by having
an easy way to uninstall.

Fix the pattern not working in neovim's now built-in editorconfig
support by removing "**/". This should have matched all paths, but it
doesn't work with the built-in parser and by removing it, we apparently
match all paths too. This fixes neovim indenting with tabs in the
Makefile and shell scripts in this repository.

Happy to see that this is a built-in feature now \o/

mobile-config-firefox does not need to support versions prior to the
oldest supported FF ESR release (there might be two at the same time).
The current oldest ESR is 115. Remove related code.

As time of writing, it is 120 and ESR 115.

As suggested by Robert Mader in issue 57, thanks.

Thanks to plata-gl for pointing this out. Fix #61.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

This fixes one of the issues from #52, but I have not been able to
reproduce the others on Phosh.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Since Firefox 104 the Services global is available automatically and no
longer needs to be imported, and since Firefox 117 importing it is an
error.

Previously the Firefox version would be detected as 0 on the first
start, causing popups.before-ff-108.css to be included even on newer
versions, which breaks touch input.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Firefox 113 changes from 'display: -moz-box' to 'display: flex', so the
-moz-box-flex property should be changed to flex-grow. However, that
breaks the tab menu, and it doesn't seem to be necessary anyway.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Without this fix, the tab menu is only tall enough for 2 or 3 entries.

This is an update of the rule directly above it, changing the ID and
changing from a calculated height to a fixed height matching its child
#allTabsMenu-allTabsView. With the calculated height, the menu entries
were offset above the top of the menu. The previous rule no longer seems
to be necessary, at least in Firefox 102 and newer, since
#allTabsMenu-multiView does not exist.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Firefox 113 changes from 'display: -moz-box' to 'display: flex', so we
need to use the order property instead of -moz-box-ordinal-group.

On first start, only restart Firefox once after the files are
installed.

[2023-04-18 07:07:05] Running mobile-config-autoconfig.js
[2023-04-18 07:07:05] Couldn't get Firefox version (expected on first start): TypeError: Services.appinfo.lastAppVersion is null
[2023-04-18 07:07:05] Firefox version: 0 (previous: unknown)
[2023-04-18 07:07:05] Creating CSS file from fragments: /home/user/.mozilla/firefox/ah7sid6m.default-release/chrome/userChrome.css
…
[2023-04-18 07:07:05] Updating previous Firefox version to: 0
[2023-04-18 07:07:05] Triggering Firefox restart
[2023-04-18 07:07:05] Done
[2023-04-18 07:07:11] Running mobile-config-autoconfig.js
[2023-04-18 07:07:11] Firefox version: 102 (previous: 0)
[2023-04-18 07:07:11] Reading fragments from file: /etc/mobile-config-firefox/userChrome.files
[2023-04-18 07:07:11] Fragment with FF version check included: userChrome/popups.before-ff-108.css
[2023-04-18 07:07:11] File is up-to-date: /home/user/.mozilla/firefox/ah7sid6m.default-release/chrome/userChrome.css
[2023-04-18 07:07:11] Reading fragments from file: /etc/mobile-config-firefox/userContent.files
[2023-04-18 07:07:11] File is up-to-date: /home/user/.mozilla/firefox/ah7sid6m.default-release/chrome/userContent.css
[2023-04-18 07:07:11] Updating previous Firefox version to: 102
[2023-04-18 07:07:11] Setting default preferences
[2023-04-18 07:07:11] Done

Refactor the condition code, so it's easier to read.

On first run / after:
$ rm ~/.mozilla

The function fails with:
TypeError: Services.appinfo.lastAppVersion is null

Expect the failure so the script doesn't crash.
Revert "autoconfig: get_firefox_version: remove try…catch", but
with another error message.

Without this patch an error shows up when starting Firefox with the
config, until the user manually starts it again.

This reverts commit 2405aabd.

Make the bookmarks panel usable again by hiding all controls except for
the name, the "show editor when saving" checkbox and the remove bookmark
/ save buttons.

This part is unrelated to generating the CSS files, so move it towards
the end.

There is a try…catch around main() now, which logs the exception and
fails with an error that is visible for the user.

Don't regenerate the firefox config if a part of the version changed
that isn't the major version as this would just lead to needless
regernations and slightly delayed startup.