Skip to content
Snippets Groups Projects
New look: Off

Make the search completion / suggestion window look nicer with current firefox

    • Open Issue created by Oliver Smith @ollieparanoid

    In !75 (merged) @1peter10 wrote:

    Remaining issues:

    • narrow suggestion window in FF 136 (I have tried setting a wider width, which works on 136, but had negative side effects on ESR 128 - the URLbar would move when activated),
    • vertical order and spacing could be better, especially with mcf.addressbarontop=true.

    Screenshot: https://fosstodon.org/@linmob/114230952197468751

    Screenshot how it used the full width in previous FF versions: https://fosstodon.org/@ollieparanoid/107394750533689867

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Oliver Smith changed milestone to %NLnet: Browser Chrome Enhancements

      changed milestone to %NLnet: Browser Chrome Enhancements

    • Danny Colin
      Danny Colin @dannycolin ·
      Reporter

      After experimenting, I was able to get close to the previous behaviour. However, there are a few things I'd like to discuss before moving forward with the implementation.

      1. We're targeting selectors that don't seem to exist anymore in Release. I didn't confirm if it was also the case in ESR.
      2. We're supporting both ESR and Release. To do so, we conditionally load a some of our rules. In general, I'm in favor of this approach but upstream can radically and rapidly change on the Release channel. I'd like to propose that we completely separate our code for both version so we can be closer to upstream code when targeting selectors. This should help use avoid some breakages and the need for !important which makes our code less flexible.
      3. We should document the visual design that we want and make sure we stick to a common UX vision when applying changes. This is something I'd propose we talk more during our next meeting.

      @ollieparanoid @1peter10 I'd appreciate your thoughts on 1 and 2.

    Please register or sign in to reply