Skip to content
Snippets Groups Projects

Fix bookmarks menu on current Firefox (124)

Merged Imported Administrator requested to merge fix-bookmarks into master
All threads resolved!

This MR fixes the bookmarks popup on current Firefox. It was intended to be a pure port-over of user0's fixes (which worked fine on Plasma Mobile). In last minute testing, it turned out to be broken on Sxmo, as it kept covering the keyboard there.

This implementation is closer to the previous implementation and does not have the issue.

Find attached the before and after for current (124) and (ESR):

Screenshots: Dark ESR, bright 124 Before: ff-115_esr-bookmarks ff-124-bookmarks

After: ff-115_esr-bookmarks-fix ff-124-bookmarks-fix

Edited by Administrator

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator
  • Author Owner

    Could you squash the commits into one? (git rebase -i origin/master, then change the lines from pick pick pick to pick squash squash; using first letter s instead of squash also works)

    Very nice, thank you so much! :grinning:

    By Oliver Smith on 2024-03-25T19:30:01

    Edited by Ghost User
  • Administrator added 1 commit · Imported

    added 1 commit

    • a8e9bce0 - Fix bookmark menu on Firefox 124, bump copyright

    Compare with previous version

    By Peter M on 2024-03-25T19:27:06

  • Administrator resolved all threads · Imported

    resolved all threads

    By Peter M on 2024-03-25T19:29:42

  • Administrator approved this merge request · Imported

    approved this merge request

    By Oliver Smith on 2024-03-27T19:14:48

  • Administrator added 1 commit · Imported

    added 1 commit

    • f0cada5a - Fix bookmark menu on Firefox 124, bump copyright (MR 46)

    Compare with previous version

    By Oliver Smith on 2024-03-27T19:15:44

  • Administrator merged · Imported

    merged

  • Please register or sign in to reply
    Loading