Skip to content
Snippets Groups Projects

mobile-config-autoconfig.js: set browser.urlbar.trimHttps to true and use xdg-desktop-portal file-picker

All threads resolved!

This change hides https:// in the urlbar by default, a change that can be undone. It also clarifies what the difference between defaultPref and pref is.

Fixes #14 (closed).

Previous !61 (closed): By using the xdg-desktop-portal file-picker we get a more native file-picker, e.g., on Plasma Mobile

Fixes #16 (closed).

Tested this on Sxmo first to rule out one UI candidate that may cause problems successfully without problems.

Edited by Peter Mack

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Mack marked this merge request as draft

    marked this merge request as draft

  • Peter Mack changed the description

    changed the description

  • Peter Mack marked this merge request as ready

    marked this merge request as ready

  • Peter Mack changed the description

    changed the description

    • Resolved by Peter Mack

      zed (the editor), which now supports editorconfig, introduced some unintended changes - ping me if you want me to undo these :slight_smile:

      Making these changes is fine, but please do it in a separate patch.

      EDIT: to clarify: can be in the same MR, but a separate commit for such style changes is needed, unless they are very small and only touch the same lines you are modifying anyway. So in the MR here it would be 1 commit with reformatting (with commit msg explaining how it was done), and 1 commit with the trimHttps change).

      (Also since this is doing more than editorconfig: I wonder if some CLI tool can be used to do this formatting the same way and check for it in CI; for the python code we mostly use ruff format nowadays.)

      Thanks for the MR!

      Edited by Oliver Smith
  • Peter Mack added 4 commits

    added 4 commits

    • f4d38beb...30da7374 - 2 commits from branch postmarketOS:master
    • 669bb39e - mobile-config-autoconfig.js: set to true
    • e589d193 - mobile-config-autoconfig.js: Use xdg-desktop-portal file-picker

    Compare with previous version

  • Peter Mack changed title from mobile-config-autoconfig.js: set browser.urlbar.trimHttps to true to mobile-config-autoconfig.js: set browser.urlbar.trimHttps to true and use xdg-desktop-portal file-picker

    changed title from mobile-config-autoconfig.js: set browser.urlbar.trimHttps to true to mobile-config-autoconfig.js: set browser.urlbar.trimHttps to true and use xdg-desktop-portal file-picker

  • Peter Mack changed the description

    changed the description

  • Peter Mack mentioned in merge request !61 (closed)

    mentioned in merge request !61 (closed)

  • Peter Mack resolved all threads

    resolved all threads

  • Oliver Smith approved this merge request

    approved this merge request

  • Oliver Smith added 5 commits

    added 5 commits

    • e589d193...a27569bd - 3 commits from branch postmarketOS:master
    • 48d51b65 - mobile-config-autoconfig.js: set browser.urlbar.trimHttps to true (MR 60)
    • 42369a2a - mobile-config-autoconfig.js: Use xdg-desktop-portal file-picker (MR 60)

    Compare with previous version

  • Very nice, thanks!

  • merged

Please register or sign in to reply
Loading