Adjust to the pmbootstrap flag rename. It was called uefi in my wip
branch, but then efi in the final implementation (which Craftyguy did).

Now that we use meson instead of make, this make clean command fails.
Remove it. We could clean up meson build artefacts too, but not sure if
that is needed or if we would just use a different build dir anyway - we
can still add it later if needed.

In theory checkpatch.pl should use its spelling.txt to check for spell
errors in the code, but it seems to be broken for some reason. It also
has code to use codespell's dictionaries... but just use codespell
directly.

../src/pages.c:289:25: error: implicit conversion from ‘enum od2_storage_id’ to ‘enum od2_button’ [-Werror=enum-conversion]
../src/ui.c:331:21: error: implicit conversion from ‘enum od2_button’ to ‘enum od2_storage_id’ [-Werror=enum-conversion]

There's also LV_UNUSED, but let's not include lvgl headers just for
that.

../src/config.c:27:29: error: unused parameter ‘ud’ [-Werror=unused-parameter]
../src/install.c:269:32: error: unused parameter ‘arg’ [-Werror=unused-parameter]

../src/cmd.c:18:16: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]

../src/ui.c: In function ‘od2_ui_on_button’:
../src/ui.c:236:9: error: enumeration value ‘OD2_PAGE_WAIT’ not handled in switch [-Werror=switch]
  236 |         switch (page_id_current()) {
      |         ^~~~~~
../src/ui.c:236:9: error: enumeration value ‘_OD2_PAGE_MAX’ not handled in switch [-Werror=switch]

../src/ui_cli.c:147:16: error: unused variable ‘len’ [-Werror=unused-variable]

../src/storages.c: In function ‘od2_storage_init’:
../src/storages.c:204:9: error: enumeration value ‘_OD2_STORAGE_UNKNOWN’ not handled in switch [-Werror=switch]
  204 |         switch (g_boot_dev_id) {
      |         ^~~~~~
../src/storages.c:204:9: error: enumeration value ‘OD2_STORAGE_EMMC’ not handled in switch [-Werror=switch]
../src/storages.c:204:9: error: enumeration value ‘OD2_STORAGE_NVME’ not handled in switch [-Werror=switch]
../src/storages.c:204:9: error: enumeration value ‘_OD2_STORAGE_MAX’ not handled in switch [-Werror=switch]
../src/storages.c: In function ‘od2_storage_repartition’:
../src/storages.c:250:9: error: enumeration value ‘_OD2_STORAGE_UNKNOWN’ not handled in switch [-Werror=switch]
  250 |         switch (id) {
      |         ^~~~~~
../src/storages.c:250:9: error: enumeration value ‘OD2_STORAGE_SD’ not handled in switch [-Werror=switch]
../src/storages.c:250:9: error: enumeration value ‘_OD2_STORAGE_MAX’ not handled in switch [-Werror=switch]

../src/storages.c: In function ‘get_boot_dev’:
../src/storages.c:72:21: error: unused variable ‘ret’ [-Werror=unused-variable]
   72 |         const char *ret = NULL;
      |                     ^~~
../src/storages.c:71:15: error: unused variable ‘buf_last’ [-Werror=unused-variable]
   71 |         char *buf_last;
      |               ^~~~~~~~

../src/storages.c:86:16: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]

../src/storages.c: In function ‘od2_storage_get_path’:
../src/storages.c:41:9: error: enumeration value ‘_OD2_STORAGE_UNKNOWN’ not handled in switch [-Werror=switch]
   41 |         switch (id) {
      |         ^~~~~~
../src/storages.c:41:9: error: enumeration value ‘_OD2_STORAGE_MAX’ not handled in switch [-Werror=switch]

Doing the compare here is fine, as the enum values are kept in sync
intentionally (see comments in storages.h and pages.h).

../src/pages.c: In function ‘od2_page_get_button_text’:
../src/pages.c:270:16: error: comparison between ‘enum od2_button’ and ‘enum od2_storage_id’ [-Werror=enum-compare]
  270 |         if (id > _OD2_STORAGE_UNKNOWN && id < _OD2_STORAGE_MAX)
      |                ^
../src/pages.c:270:45: error: comparison between ‘enum od2_button’ and ‘enum od2_storage_id’ [-Werror=enum-compare]
  270 |         if (id > _OD2_STORAGE_UNKNOWN && id < _OD2_STORAGE_MAX)
      |

../src/install.c:198:1: error: control reaches end of non-void function [-Werror=return-type]

../src/install.c:286:15: error: unused variable ‘pid’ [-Werror=unused-variable]
  286 |         pid_t pid;
      |               ^~~
../src/install.c:285:13: error: unused variable ‘rc’ [-Werror=unused-variable]
  285 |         int rc;
      |

../src/install_steps.c:214:16: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]

Casey authored 1 year ago and Oliver Smith committed 1 year ago

This way the layout engine will still account for it, so the header text
will be in a consistent location regardless of if the back button is
visible.

Casey authored 1 year ago and Oliver Smith committed 1 year ago

Notes by Oliver:
* Caleb forked unl0kr to implement not-yet merged fbdev and libinput
  fixes, and to adjust the unl0kr source to make everything build with
  meson.
* Squashed these commits from Caleb into one:
  * unl0kr: update for fbdev/libinput fixes
  * switch to meson + temp unl0kr fork
  * unl0kr: move to subprojects/ for meson
  * build system fixes for packaging
* Use current head of ondev2-meson branch in Caleb's unl0kr.git fork
* I've considered removing the git submodule and only using meson wrap,
  but that doesn't work since we also have git submodules in unl0kr.git
  and therefore need to use the recursive submodule init. Let's use
  both for now, we plan to merge unl0kr.git and ondev2.git in a near
  future, then we can look into making the submodules/wrap logic nicer.
* Made test/run-test-host-losetup.sh work without existing build dir,
  removed -Dtest=true in the script as meson complained about it.
* Configure --werror (with warning_level=0 for now, same level as with
  the Makefile, let's bump it in the future) and fix the
  ul_themes_themes pointer error it shows (caused random colors)
* Removed the Makefile
* Various cosmetic fixes
* Adjust CI to use meson

Casey authored 1 year ago and Oliver Smith committed 1 year ago

Notes by Oliver:
* Squashed two of Caleb's patches:
  * install: switch to pthread
  * install: pthread use barrier
* Fixed linting error

Add the missing closedir(), so we don't leak a file descriptor. This
happened to work with existing fork code, but will not work anymore when
switching to pthreads in the next commit.

Checkpatch warns about it as it doesn't make sense to use it in the
kernel (see Documentation/process/volatile-considered-harmful.rst).
However we'll use it properly for multithread code in a follow-up
patch.

Checkpatch recommends using strscpy instead, which is only defined in
the kernel. Might be a good idea to copy it over into the source here
too in the future and use that, but let's not use it for now.

Speed up the test by reusing the installation image, only replacing the
boot partition of it. This way the dd of the to-be-installed root image
does not need to be every time one runs the test.

This can be used as long as we don't extend the installed OS over the
image at the end (which ondev2 may do in the future).

Fix the bug that when running on the PinePhone, sometimes the page with
progress would not appear. Thanks to Caleb for figuring it out!

Related: https://www.openssl.org/docs/faq.html

Bump it so it finishes when running on the PinePhone.

Related: https://gitlab.com/postmarketOS/postmarketos-mkinitfs/-/tags/2.0

* Only show the keyboard button if the page has a text input.
* Only show the keyboard layout dropdown if the on-screen keyboard is
  active.
* Remember if the user toggled the button, and use the same state on the
  next page with a text input (as opposed to always showing/hiding,
  depending on if there's a physical keyboard).
* Use the LVGL hidden flag to hide the object, not the vertical
  position.

The keyboard animation code was currently unused in ondev2. I think it
looks pretty cool in unl0kr when booting it up. But not sure how useful
it is during the installation, with the multiple pages we have here etc.
Remove it for now.

A follow-up patch will only show the keyboard layout dropdown if the
on-screen keyboard is visible. Swap it with the keyboard button, so the
button doesn't change its position when the dropdown appears.

Prepare to hide the keyboard button + dropdown for all pages that don't
have text input. Move the contrast button to the right of it, so it
doesn't change position when the keyboard button/dropdown show up.

Fix that it aborts here if a filesystem already exists:
  /dev/mmcblk2p1 contains a ext2 file system labelled 'pmOS_boot'
          last mounted on /mnt/install-boot on Thu Jan  1 00:00:50 1970
  Proceed anyway? (y,N)