gtk4 apps crash on launch (half the time?)

Describe your issue

What's the expected behaviour?

Touching the icons for gnome-calculator, gnome-control-center, and gnome-clocks opens the program every time

What's the current behaviour?

Sometimes it doesn't (about half the time)

How to reproduce your issue?

• Clean install of pinephone/edge/phosh
• Touch one of the icons for clocks/calculator/settings and observe it only opens half the time
• Alternatively, run gnome-calculator, gnome-control-center, and gnome-clocks from the terminal and observe the output below

What device are you using?

pine64-pinephone

On what postmarketOS version did you encounter the issue?

• edge (master branch)
• v21.12

On what environment did you encounter the issue?

Phone environments

• Phosh
• Plasma Mobile
• Sxmo (Wayland/Sway)

Other

• No environment ("none" in pmbootstrap)
• GNOME
• KDE Plasma
• Kodi
• MATE
• Shelli
• Sway
• Weston
• Xfce4
• fbkeyboard
• i3wm
• Sxmo (Xorg/Dwm)
• console UI
• framebufferphone

How did you get postmarketOS image?

• from https://images.postmarketos.org
• I built it using pmbootstrap
• It was preinstalled on my device

What's the build date of the image? (in yyyy-mm-dd format)

2022-04-27

Additional information

18:26 $ gnome-calculator
**
Gsk:ERROR:../gsk/gl/gskglcommandqueue.c:1276:gsk_gl_command_queue_create_render_target: assertion failed (glCheckFramebufferStatus (GL_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE): (0x00008cd6 == 0x00008cd5)
Bail out! Gsk:ERROR:../gsk/gl/gskglcommandqueue.c:1276:gsk_gl_command_queue_create_render_target: assertion failed (glCheckFramebufferStatus (GL_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE): (0x00008cd6 == 0x00008cd5)
Aborted

Upon some searching, I found a Debian issue too: https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1851540.html

Which links to a gtk issue: https://gitlab.gnome.org/GNOME/gtk/-/issues/4763

And a patch: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4570.patch

I don't want to recommend downstream patching, especially when upstream is working on it, but this is a pretty big issue. Would it be easy enough to patch in postmarketos?

By Adam Thiede on 2022-04-28T13:04:09

Yes, this is an issue, and like you have seen in issue 4763 and MR 4570 in the gtk repo, it is in the process of being fixed. The original patch that you propose has been rejected by upstream because it reverts one specific commit and could reintroduce a known bug, so we cannot unfortunately add that patch downstream. I proposed an alternative solution, but need feedback from somebody that knows better. Unfortunately these kind of changes in the GL initialization code can have a lot of side-effects in other phones/devices which I do not have to test. So we need to call the attention from GTK devs and wait for them to have the time to look into it before we can patch it downstream

By Pablo Correa Gomez on 2022-04-30T12:43:29

added type::bug + 1 deleted label

removed 1 deleted label

added release-edge label

added device-pine64-pinephone label

Thanks for helping out @pabloyoyoista. I might try to build with your patch and see if that helps things out for me.

By Adam Thiede on 2022-05-02T12:45:10

Looks like the real fix is going to take a bit: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4687#note_1444626

Temporarily, one of the possibilities would be to fork GTK4 in pmOS and add the dirty patch that I proposed. It works in the pinephone, but would need more testing from people with other devices to make sure nothing breaks. For edge this is just a (big) inconvenience, but if the real patch is not ready for the stable release, then some hack must be set in place instead, or default phosh installation on the pp will have a huge regression in terms of usability.

By Pablo Correa Gomez on 2022-05-05T11:57:54

mentioned in merge request !3122 (merged)

By Pablo Correa Gomez on 2022-05-08T18:53:28

Documenting this here: patches in !3122 (merged) fix the issue; mrtest add 3122 and selecting u will get gtk4 programs working reliably.

By Adam Thiede on 2022-05-09T15:21:29

closed

closed with commit 72075de4

mentioned in commit 72075de4

By Pablo Correa Gomez on 2022-05-14T14:13:33

added status::notourbug label and removed 1 deleted label