Skip to content
Snippets Groups Projects
New look: Off

Create common postmarketos-ui package

    • Closed Imported Issue created by Administrator @root

    Superseded by #467 (closed).

    @minlexx had a proposal in !971 (comment 292724395):

    Would it be good if had something like postmarketos-ui-common package that gathers all the thigs needed by UIs, except none?

    and https://gitlab.postmarketos.org/postmarketos/pmaports/-/merge_requests/975#note_292724486:

    Another reason to have ui-common package...

    I like the idea!

    Maybe I'd name it postmarketos-base-ui though, so we could add it as subpackage to postmarketos-base, and still have a subpackage name that makes obvious where the package comes from. If we really added a new postmarketos-ui-common package, we would need to make an exception in pmbootstrap init, so it does not show up as UI.

    TODO:

    • add postmarketos-base-ui subpkg to postmarketos-base
    • let all postmarketos-ui-* packages depend on it (except for postmarketos-ui-none)

    Any takers?

    0 of 2 checklist items completed · Edited
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Administrator added help wanted type::feature labels · Imported

      added help wanted type::feature labels

    • Administrator
      Administrator @root · Imported
      Author Owner

      That's a great idea! Do you think it would make sense to have a postmarketos-ui-wayland subpackage that gets installed with plamo, phosh and (maybe) sway? It would force apps to use the wayland backend

      export GDK_BACKEND=wayland
export QT_QPA_PLATFORM=wayland
export SDL_VIDEODRIVER=wayland

      By Antoine Fontaine on 2020-02-24T07:15:28

    • Administrator
      Administrator @root · Imported
      Author Owner

      It would also be nice to launch dbus and ensure XDG_RUNTIME_DIR is set for all UI. I'll open a separate issue for that.

      By Antoine Fontaine on 2020-02-24T07:24:31

    • Administrator
      Administrator @root · Imported
      Author Owner

      Although I liked the idea at first, I'm not so sure this is actually a good idea. What would we put in these packages?

      Taking the examples that spawned this issue:

      Ofono. Not every DE depends on Ofono. Actually, it's probably just Plasma Mobile and (maybe) Phosh that so-far depend on Ofono. I rather fix up those packages properly then put it in some common package which then causes Ofono to be installed in DE's that don't need it (e.g. currently Hildon, Mate, XFCE4, Weston, etc).

      PulseAudio. Really a dependency of the shell or at least specific meta UI packages. Someone using XFCE4 might not want PulseAudio, so why would we force it upon them? Again I think we should solve this directly in the respective UI packages.

      We're quite opinionated about the system as we are already, and at least @ddevault has been trying to lessen that. I think we should try to follow his lead.

      By Bart Ribbers on 2020-02-24T14:49:17

      Edited by Administrator
      • Administrator
        Administrator @root · Imported
        Author Owner

        At the moment pulseaudio is a depends of postmarketos-base, which is (arguably) even worse than having it in a postmarketos-base-ui package. :)

        By Minecrell on 2020-02-24T20:45:40

        Edited by Ghost User
      • Administrator
        Administrator @root · Imported
        Author Owner

        I agree, we should remove it from postmarketos-base and add it to the DE UI packages that need it.

        By Bart Ribbers on 2020-02-24T20:45:40

      • Please register or sign in to reply
    • Administrator
      Administrator @root · Imported
      Author Owner

      After some discussions, I agree with @PureTryOut now. Let's not create a postmarketos-base-ui package that forces dependencies for every UI even if they don't need them, like pulseaudio. Let's move them to the specific UI packages, like postmarketos-ui-plasma-mobile instead, and remove them from postmarketos-base. Created new issue: #467 (closed).

      By Oliver Smith on 2020-02-29T19:54:16

    • Administrator closed · Imported

      closed

      By Oliver Smith on 2020-02-29T19:54:29

    • Administrator changed the description · Imported

      changed the description

      By Oliver Smith on 2020-02-29T19:55:11

    • Administrator mentioned in merge request !1033 (merged) · Imported

      mentioned in merge request !1033 (merged)

      By Oliver Smith on 2020-03-14T00:20:29

    Please register or sign in to reply