device/linux-*: fix various linter warnings, remove HOSTCC where possible

This builds on the work in !976 (closed) and fixes the majority of linter warnings in the downstream kernel packages. It also removes setting HOSTCC when using latest GCC as it is not needed.

$ pmbootstrap lint linux-* | wc -l

• Before: 1101
• After: 19

The main remaining linter warnings are because of a number of weird APKBUILDs with ksrcdir variables. They don't use our downstreamkernel_* functions at all so it's likely easier to fix them by regenerating/or changing them to use downstreamkernel_*. (Not as part of this MR...)

This change is a mixture of automated changes and custom ones, I tried to split it into useful commits.

added type::feature + 1 deleted label

ksrcdir may probably also be renamed to _ksrcdir.. but not necessarily in this MR.

By Alexey Min on 2020-02-28T17:42:46

added 6 commits

• 58bbc551 - main/devicepkg-dev: make HOSTCC optional
• c1ffdff3 - device/linux-*: remove HOSTCC for kernels using latest GCC
• f59bfb1c - device/linux-*: remove all usages of _vendor
• acf65ea1 - device/linux-*: remove unneeded braces from variables
• 52f27215 - device/linux-*: various custom linter fixes
• 2d5c4867 - device/linux-*: remove empty variables

Compare with previous version

By Minecrell on 2020-02-28T18:02:51

resolved all threads

By Minecrell on 2020-02-28T18:03:56

approved this merge request

By Alexey Min on 2020-02-28T18:25:17

I have tested that all kernels still build correctly. The only two kernels that fail to build are:

• linux-lg-bullhead
• linux-motorola-athene

but they were already broken before this MR (some weird WireGuard stuff).

By Minecrell on 2020-02-28T20:34:18

changed the description

By Minecrell on 2020-02-28T20:34:29

approved this merge request

By Bart Ribbers on 2020-02-28T23:26:12

mentioned in commit fde2a02e

By Minecrell on 2020-02-28T23:28:02

mentioned in commit 6254328c

By Minecrell on 2020-02-28T23:28:02

mentioned in commit 447b2e6f

By Minecrell on 2020-02-28T23:28:02

mentioned in commit ed2333c2

By Minecrell on 2020-02-28T23:28:02

mentioned in commit 46371f04

By Minecrell on 2020-02-28T23:28:02

mentioned in commit ea583fc6

By Minecrell on 2020-02-28T23:28:02

added 6 commits

• 46371f04 - main/devicepkg-dev: make HOSTCC optional (!1007 (merged))
• 447b2e6f - device/linux-*: remove HOSTCC for kernels using latest GCC (!1007 (merged))
• ed2333c2 - device/linux-*: remove all usages of _vendor (!1007 (merged))
• fde2a02e - device/linux-*: remove unneeded braces from variables (!1007 (merged))
• ea583fc6 - device/linux-*: various custom linter fixes (!1007 (merged))
• 6254328c - device/linux-*: remove empty variables (!1007 (merged))

Compare with previous version

By Bart Ribbers on 2020-02-28T23:28:03

merged

By Bart Ribbers on 2020-02-28T23:28:12