samsung-i9100: Change arch to armv7

added 1 commit

b352dfa1 - samsung-i9100: Change arch to armv7

By Paul Cercueil on 2020-03-18T12:08:27

approved this merge request

By Minecrell on 2020-03-18T12:13:40

added category::device type::feature labels

@pcercuei thanks for your MR! Please fix the linting issue while you're at it:

Linting issues found:
firmware/firmware-samsung-i9100/APKBUILD: MC:[AL5]:firmware/firmware-samsung-i9100/APKBUILD:23:variable set to empty string: source=""

By Bart Ribbers on 2020-03-18T12:37:27

@PureTryOut the APKBUILD does:

source=""
for _i in $_files; do
   source="$source $pkgname-$_commit-$_i::$_url/$_i";
done

So can source="" be removed if it's used later in the loop?

By Paul Cercueil on 2020-03-20T11:02:13

This line was not changed in this MR. I suggest to:

either leave it as is, with linter warning
or, do not use loop to fill sources variable at all. Instead of

# Source
_files="
	bcmdhd_apsta.bin
	bcmdhd_mfg.bin
	bcmdhd_p2p.bin
	bcmdhd_sta.bin
	nvram_mfg.txt
	nvram_mfg.txt_murata
	nvram_net.txt
	nvram_net.txt_murata
"

use directly

_url="https://github.com/TheMuppets/proprietary_vendor_samsung/raw/$_commit/i9100/proprietary/system/etc/wifi"
source="
	$pkgname-$_commit-bcmdhd_apsta.bin::$_url/bcmdhd_apsta.bin
	$pkgname-$_commit-bcmdhd_mfg.bin::$_url/bcmdhd_mfg.bin
	...bcmdhd_p2p.bin
	...bcmdhd_sta.bin
	...nvram_mfg.txt
	...nvram_mfg.txt_murata
	...nvram_net.txt
	$pkgname-$_commit-nvram_net.txt_murata::$_urlnvram_net.txt_murata
"

... without loops, in other words in line $pkgname-$_commit-$_i::$_url/$_i replace all $_i with each file name.

By Alexey Min on 2020-03-20T12:20:50

approved this merge request

By Oliver Smith on 2020-03-21T20:55:36

added 44 commits

b352dfa1...2853de8e - 43 commits from branch postmarketOS:master
72702212 - samsung-i9100: Change arch to armv7 (!1074 (merged))

Compare with previous version

By Oliver Smith on 2020-03-21T20:56:19

resolved all threads

By Oliver Smith on 2020-03-21T20:56:35

So can source="" be removed if it's used later in the loop?

Yep. I've removed the line, the loop is still working as it should.

Thanks for the patch, @pcercuei!

By Oliver Smith on 2020-03-21T20:58:19

enabled an automatic merge when the pipeline for 72702212 succeeds

By Oliver Smith on 2020-03-21T20:58:39

added 1 commit

b14dcd09 - samsung-i9100: Change arch to armv7 (!1074 (merged))

Compare with previous version

By Oliver Smith on 2020-03-21T21:00:20

enabled an automatic merge when the pipeline for b14dcd09 succeeds

By Oliver Smith on 2020-03-21T21:00:38

merged

By Oliver Smith on 2020-03-21T21:02:15

mentioned in commit b14dcd09

By Paul Cercueil on 2020-03-26T14:57:49

samsung-i9100: Change arch to armv7

Merge request reports

Activity