devicepkg-dev: implement out-of-tree build for downstream kernels

Closes #493 (closed) and depends on pmbootstrap!1893 (merged)

Kernels that do not compile:

• linux-motorola-athene: doesn't compile at least since !976 (closed)
• linux-lg-bullhead: doesn't compile at least since !976 (closed)

changed the description

By Dolphin von Chips on 2020-03-21T08:50:17

changed the description

By Dolphin von Chips on 2020-03-21T08:54:26

added type::feature + 1 deleted label

marked the checklist item successfully build a kernel out-of-tree as completed

By Dolphin von Chips on 2020-03-22T07:35:23

added 23 commits

• 99c0a3bf...3bbd7992 - 22 commits from branch postmarketOS:master
• e70efed2 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-22T11:16:24

marked the checklist item verify that it doesn't break in-tree builds as completed

By Dolphin von Chips on 2020-03-22T11:37:46

mentioned in merge request !1040 (merged)

By Minecrell on 2020-03-24T10:10:54

added 10 commits

• e70efed2...8a455929 - 9 commits from branch postmarketOS:master
• 606196bc - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-25T09:06:09

added 1 commit

• fbfc3a8d - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-25T09:11:07

mentioned in merge request pmbootstrap!1893 (merged)

By Dolphin von Chips on 2020-03-25T12:32:24

added 1 commit

• 62e013c3 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-25T16:09:33

added 23 commits

• 62e013c3...9434ea1b - 22 commits from branch postmarketOS:master
• 12782509 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-29T14:41:42

added 1 commit

• a987b850 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-29T14:58:54

resolved all threads

By Dolphin von Chips on 2020-03-29T15:14:33

I've changed the way how downstreamkernel_prepare should be called, now it's . downstreamkernel_prepare instead of downstreamkernel_prepare ....

Advantages:

• no need to pass arguments to downstreamkernel_prepare, it gets them automatically from abuild and APKBUILD since script is sourced
• both $HOSTCC and $_outdir can be optional \o/

Disadvantages:

• prepare() function should be changed in 140 kernels /o\ (although it's just prepare(), so at least I don't have to fully rebuild all kernels)

By Dolphin von Chips on 2020-03-29T15:26:28

marked the checklist item pretty up some parts as completed

By Dolphin von Chips on 2020-03-29T16:19:44

I'm more for using source downstreamkernel_package instead of . downstreamkernel_package but imo both aren't overly pretty.

By Luca Weiss on 2020-03-29T19:38:52

added 1 commit

• f83127a6 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-30T16:42:38

added 1 commit

• 4c6735b0 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-30T17:00:41

added 1 commit

• 664bd736 - devicepkg-dev: implement out-of-tree build for kernel

Compare with previous version

By Dolphin von Chips on 2020-03-30T17:00:58

added 20 commits

• 664bd736...c747733a - 18 commits from branch postmarketOS:master
• c86ccefa - devicepkg-dev: implement out-of-tree build for kernel
• eea4d517 - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-01T07:21:39

added 1 commit

• 0330e39c - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-01T07:24:09

added 1 commit

• 46d7e39b - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-01T07:28:27

added 1 commit

• fc159764 - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-01T07:36:22

added 1 commit

• 3dba5f3f - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-01T07:42:13

unmarked as a Work In Progress

By Dolphin von Chips on 2020-04-01T08:15:38

changed the description

By Dolphin von Chips on 2020-04-01T08:25:00

resolved all threads

By Minecrell on 2020-04-01T11:22:50

I think it's a bit weird that only downstreamkernel_prepare does it like that now, but not downstreamkernel_package. Also I think we should try to enable out of tree build for all kernels eventually.

I guess both can be done in separate changes, therefore

By Minecrell on 2020-04-01T11:55:23

approved this merge request

By Minecrell on 2020-04-01T11:26:58

linux-fairphone-fp1 still builds fine for me on master..

>>> linux-fairphone-fp1: Build complete at Wed, 01 Apr 2020 18:58:02 +0000 elapsed time 0h 4m 46s

So if it doesn't build anymore with the MR, then you must have broken something.

By Luca Weiss on 2020-04-01T20:25:17

added 1 commit

• fca42b69 - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-02T13:18:02

added 2 commits

• 1ef45daa - devicepkg-dev: implement out-of-tree build for kernel
• 0e43f4e2 - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-02T13:24:40

resolved all threads

By Dolphin von Chips on 2020-04-02T13:25:21

changed the description

By Dolphin von Chips on 2020-04-02T13:57:41

added 2 commits

• 24d1243b - devicepkg-dev: implement out-of-tree build for kernel
• 13ad3d7c - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-02T14:57:59

approved this merge request

By Oliver Smith on 2020-04-05T00:37:24

LGTM. I'd merge this tomorrow unless anyone objects.

Thank you very much, @DolphinChips!

By Oliver Smith on 2020-04-05T00:38:25

added 8 commits

• 13ad3d7c...8af4d8c2 - 6 commits from branch postmarketOS:master
• c4eee840 - devicepkg-dev: implement out-of-tree build for kernel
• e21015e1 - **/linux-*: update usage of downstreamkernel_prepare helper

Compare with previous version

By Dolphin von Chips on 2020-04-05T06:22:57

resolved all threads

By Dolphin von Chips on 2020-04-05T06:23:46

added 2 commits

• a4b1fb83 - devicepkg-dev: implement out-of-tree build for kernel (!1084 (merged))
• 555fbdea - **/linux-*: update usage of downstreamkernel_prepare helper (!1084 (merged))

Compare with previous version

By Oliver Smith on 2020-04-05T10:31:34

A check for wrong usage was missing, so I've added it. Merging after CI passes.

if [ "$#" -ne 0 ]; then
	echo "ERROR: downstreamkernel_prepare should be sourced in APKBUILDs."
	echo "Related: https://postmarketos.org/downstreamkernel-prepare"
	exit 1
fi

By Oliver Smith on 2020-04-05T10:35:52

approved this merge request

By Oliver Smith on 2020-04-05T10:36:16

enabled an automatic merge when the pipeline for 555fbdea succeeds

By Oliver Smith on 2020-04-05T10:36:20